Skip to content

chore: park the unused Lua-level DCE on the lua-dce-wip branch #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Unisay merged 1 commit into from
Jul 2, 2026
Merged

chore: park the unused Lua-level DCE on the lua-dce-wip branch #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/Language/PureScript/Backend.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ compileModules outputDir foreignDir appOrModule = do
-- See Note [The PSLUA_runtime_lazy coupling] in Language.PureScript.Names
let needsRuntimeLazy = Tagged (any untag needsRuntimeLazys)
chunk ← Lua.fromUberModule foreignDir needsRuntimeLazy appOrModule uberModule
-- A Lua-level DCE pass used to run here, between codegen and 'optimizeChunk'
-- (unplugged in 189173d when the IR-level DCE inside 'optimizedUberModule'
-- took over). The unfinished module is parked on the 'lua-dce-wip' branch;
-- its known defects are documented there in
-- Note [Graph-based dead code elimination for Lua].
Comment thread
Unisay marked this conversation as resolved.
let optimizedChunk = optimizeChunk chunk
-- Safety net: reject a chunk that nests too deeply for Lua 5.1's parser
-- rather than emit Lua that cannot be loaded (issue #104). Catches whatever
Expand Down
Loading
Loading