Skip to content

Switch the IR pipeline to globally unique local names #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Unisay merged 14 commits into from
Jul 3, 2026
Merged

Switch the IR pipeline to globally unique local names #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6cf4962
feat: alpha-equivalence for IR terms, used by removeIfWithEqualBranches
Unisay Jul 3, 2026
4b73e6c
feat: UniqueBinders and IndicesZero invariants with linter checks
Unisay Jul 3, 2026
cf7e182
feat: uniquifyNames, the GUC-establishing entry pass (not yet wired)
Unisay Jul 3, 2026
7b45334
feat: switch the IR pipeline to globally unique local names (#139)
Unisay Jul 3, 2026
02d226e
style: pay off fourmolu debt in two untouched modules
Unisay Jul 3, 2026
55f5d79
chore: add tricorder to the dev shell
Unisay Jul 3, 2026
5fa34c8
test: direct coverage for the GUC substitution primitives
Unisay Jul 3, 2026
b927b93
docs: changelog fragment and Note walker-list completion for #139
Unisay Jul 3, 2026
efa7c67
test: generate Let bindings in scopedExp
Unisay Jul 3, 2026
65ec020
test: pin the GUC precondition and ensures-contract of DCE
Unisay Jul 3, 2026
7100ec0
refactor: extract renderPassCheckFailure for unit testing
Unisay Jul 3, 2026
67c29f4
test: alphaEq symmetry property
Unisay Jul 3, 2026
919cbde
address copilot review on PR #150
Unisay Jul 3, 2026
a927723
feat: remove the De Bruijn index from IR references
Unisay Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions changelog.d/20260703_180000_unisay_guc_unique_names.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
### Changed

- Local names in the IR pipeline follow the global-uniqueness condition
(GUC): a `uniquify` entry pass makes every local binder unique within
its top-level binding, and all later passes keep it that way
(term-duplicating rewrites freshen the binders of each inserted
copy). A local reference resolves to its binder by name alone: the
per-name De Bruijn index is gone from the IR `Ref` node, along with
the per-pass index arithmetic (`shift`/`unshift`, capture-avoiding
substitution, index-keyed DCE scopes) that caused issues #37, #56,
#133 and #134. Generated Lua changes only in the choice of local
variable names; behaviour is unchanged (#139).

- The `--lint-ir` flag (and the always-on test-suite checks) verify the
new `UniqueBinders` invariant at every pass boundary in addition to
well-scopedness (#139).
22 changes: 5 additions & 17 deletions exe/Main.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ import Data.Tagged (Tagged (..))
import Language.PureScript.Backend (CompilationResult (..))
import Language.PureScript.Backend qualified as Backend
import Language.PureScript.Backend.IR qualified as IR
import Language.PureScript.Backend.IR.Pass (PassCheckFailure (..))
import Language.PureScript.Backend.IR.Pass
( PassCheckFailure
, renderPassCheckFailure
)
import Language.PureScript.Backend.Lua qualified as Lua
import Language.PureScript.Backend.Lua.Printer qualified as Printer
import Language.PureScript.Backend.Lua.Run qualified as Run
Expand Down Expand Up @@ -119,28 +122,13 @@ handlePassCheckFailure
∷ ExceptT (Oops.Variant (PassCheckFailure ': e)) IO a
→ ExceptT (Oops.Variant e) IO a
handlePassCheckFailure =
Oops.catch \PassCheckFailure {failedPassName, failedPhase, failedViolations} →
die . toString . unlines $
[ "IR invariants violated "
<> show failedPhase
<> " optimizer pass "
<> failedPassName
<> ":"
]
<> (show <$> toList failedViolations)
Oops.catch (die . toString . renderPassCheckFailure)

handleLuaError
∷ ExceptT (Oops.Variant (Lua.Error ': e)) IO a
→ ExceptT (Oops.Variant e) IO a
handleLuaError =
Oops.catch \case
Lua.UnexpectedRefBound modname expr →
die . toString . unwords $
[ "Unexpected bound reference:"
, show expr
, "in module"
, runModuleName modname
]
Lua.LinkerErrorForeign e →
die $ "Linker error:\n" <> show e
Lua.AppEntryPointNotFound modname ident →
Expand Down
Loading
Loading