Skip to content

Rename PR remote option to --pr-remote#106

Merged
Mariatta merged 1 commit into
python:masterfrom
ncoghlan:rename-pr-remote-option
Jun 4, 2017
Merged

Rename PR remote option to --pr-remote#106
Mariatta merged 1 commit into
python:masterfrom
ncoghlan:rename-pr-remote-option

Conversation

@ncoghlan

@ncoghlan ncoghlan commented Jun 2, 2017

Copy link
Copy Markdown
Contributor

The new --push/--no-push option conflicts with the old name
of the option for setting the PR remote.

This updates the latter option to the more explicit
--pr-remote.

The new --push/--no-push option conflicts with the old name
of the option for setting the PR remote.

This updates the latter option to the more explicit
`--pr-remote`.
@ncoghlan

ncoghlan commented Jun 2, 2017

Copy link
Copy Markdown
Contributor Author

Tested by generating python/cpython#1921 and it seems to mostly work.

However, it would be good to remember the PR remote name in the --continue state file: https://github.com/python/core-workflow/issues/107 (I haven't added that yet myself, as I'll need to look into how the command continuation works)

@Mariatta Mariatta merged commit 0242435 into python:master Jun 4, 2017
@Mariatta

Mariatta commented Jun 4, 2017

Copy link
Copy Markdown
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants