Skip to content

bpo-32153: Add unit test for create_autospec with partial function returned in getattr #10398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjw296 merged 3 commits into from
Dec 3, 2018
Merged

bpo-32153: Add unit test for create_autospec with partial function returned in getattr #10398

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
757fbf4
Add create_autospec with partial function returned in getattr
tirkarthi Nov 7, 2018
d184402
Use self.assertFalse instead of assert
tirkarthi Nov 9, 2018
2e71976
Use different names and remove object
tirkarthi Nov 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Lib/unittest/test/testmock/testhelpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
)

from datetime import datetime
from functools import partial

class SomeClass(object):
def one(self, a, b):
Expand Down Expand Up @@ -871,6 +872,19 @@ def test_autospec_on_bound_builtin_function(self):
mocked.assert_called_once_with(4, 5, 6)


def test_autospec_getattr_partial_function(self):
# bpo-32153 : getattr returning partial functions without
# __name__ should not create AttributeError in create_autospec
class Foo:

def __getattr__(self, attribute):
return partial(lambda name: name, attribute)

proxy = Foo()
autospec = create_autospec(proxy)
self.assertFalse(hasattr(autospec, '__name__'))


class TestCallList(unittest.TestCase):

def test_args_list_contains_call_list(self):
Expand Down