Skip to content

bpo-29870: Free CRL DP with CRL_DIST_POINTS_free() #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tiran wants to merge 1 commit into from
Closed

bpo-29870: Free CRL DP with CRL_DIST_POINTS_free() #1085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bpo-29870: Free CRL DP with CRL_DIST_POINTS_free() 
CRL_DIST_POINTS_free() compiles and tests with OpenSSL and libressl
versions

<BuildOpenSSL for 0.9.8zc>
<BuildOpenSSL for 0.9.8zh>
<BuildOpenSSL for 1.0.1u>
<BuildOpenSSL for 1.0.2>
<BuildOpenSSL for 1.0.2k>
<BuildOpenSSL for 1.1.0e>
<BuildLibreSSL for 2.3.10>
<BuildLibreSSL for 2.4.5>
<BuildLibreSSL for 2.5.3>

I have verified that it does no longer leak on OpenSSL 1.0.2k.
  • Loading branch information
@tiran
tiran committed Apr 11, 2017
commit 7d382b87de8b6f4ba6a3a07f67f45f641b7a4ad9
4 changes: 1 addition & 3 deletions Modules/_ssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1257,9 +1257,7 @@ _get_crl_dp(X509 *certificate) {

done:
Py_XDECREF(lst);
#if OPENSSL_VERSION_NUMBER < 0x10001000L
sk_DIST_POINT_free(dps);
#endif
CRL_DIST_POINTS_free(dps);
return res;
}

Expand Down