bpo-34977: Add Windows App Store package#11027
Conversation
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
Please move the venv and tests change into a separated PR.
|
When you're done making the requested changes, leave the comment: |
|
Please run a custom build on buildbot before merging this PR, I would prefer to not have to revert the change one more time :-) |
|
How do you trigger a custom build these days? I couldn't find the UI. |
It's basically just a Git push to the right branch: See https://devguide.python.org/buildbots/#custom-builders for more info. Then you can go to https://buildbot.python.org/all/#/builders for example to see results: check the custom workers ran your job and check that they are green ;-) You should ignore unstable buildbots like Alpine or Clang UBSan custom. Well, we mostly care about Windows here :-) |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
pfmoore
left a comment
pfmoore
left a comment
There was a problem hiding this comment.
A couple of minor points, but generally this looks OK to me.
Also adds the PC/layout script for generating layouts on Windows.
5 participants
Restores the original commit, plus the fix to ensure that when building on machines without recent MSVC/WinSDK we don't fail.
https://bugs.python.org/issue34977