[3.12] gh-108447: Detect platform triplets for x86_64 GNU/Hurd (GH-108045)#111987
Closed
sthibaul wants to merge 1 commit into
Closed
[3.12] gh-108447: Detect platform triplets for x86_64 GNU/Hurd (GH-108045)#111987sthibaul wants to merge 1 commit into
sthibaul wants to merge 1 commit into
Conversation
This was referenced Nov 11, 2023
…ythonGH-108045) (cherry picked from commit edb569e)
erlend-aasland
previously approved these changes
Nov 14, 2023
erlend-aasland
left a comment
erlend-aasland
left a comment
Contributor
There was a problem hiding this comment.
Are you fine with this, Dong-hee?
erlend-aasland
dismissed
their stale review
I'm unsure if we need to backport this
Contributor
|
I changed my mind; I'm not sure it is a good idea to alter the platform triplets in 3.12 and 3.11. |
Contributor
Author
? It's not altering it, it's adding it |
Contributor
|
IMO, it's a feature; we don't backport features. What do you think, @corona10? |
Member
|
Agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit edb569e)