Skip to content

gh-112281: Allow Union with unhashable Annotated metadata #112283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 13 commits into from
Mar 1, 2024
Merged

gh-112281: Allow Union with unhashable Annotated metadata #112283

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c13aa09
gh-112281: Allow `Union` with unhashable `Annotated` metadata
sobolevn Nov 20, 2023
0ff7f84
Add one more test case
sobolevn Nov 20, 2023
d348b74
Fix ordering issues, use consistent hash check
sobolevn Nov 20, 2023
8dff1c4
More tests
sobolevn Nov 20, 2023
968dd18
Address review
sobolevn Dec 2, 2023
9f8b665
Address review
sobolevn Dec 2, 2023
a9c1700
Address review
sobolevn Dec 2, 2023
4622bc8
Address review
sobolevn Dec 2, 2023
cadb2df
Apply suggestions from code review
sobolevn Dec 2, 2023
7293ad7
Apply suggestions from code review
sobolevn Dec 2, 2023
449f114
Update Lib/test/test_typing.py
sobolevn Dec 2, 2023
da80e22
Merge branch 'main' into issue-112281
sobolevn Feb 7, 2024
98cf0ff
Merge branch 'main' into issue-112281
AlexWaygood Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add one more test case
  • Loading branch information
@sobolevn
sobolevn committed Nov 20, 2023
commit 0ff7f847f6f29c5041f9677e1981b0bacb76fb6c
4 changes: 4 additions & 0 deletions Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8319,8 +8319,12 @@ class ValueRange:
# Unhashable metadata duplicated:
self.assertEqual(Annotated[int, {}] | Annotated[int, {}] | int,
Annotated[int, {}] | int)
self.assertEqual(Annotated[int, {}] | Annotated[int, {}] | int,
int | Annotated[int, {}])
self.assertEqual(Union[Annotated[int, {}], Annotated[int, {}], int],
Union[Annotated[int, {}], int])
self.assertEqual(Union[Annotated[int, {}], Annotated[int, {}], int],
Union[int, Annotated[int, {}]])

def test_specialize(self):
L = Annotated[List[T], "my decoration"]
Expand Down