gh-56634: Gettext: raise descriptive ValueErrors instead of IndexErrors for incorrect .mo files metadata#112895
Open
m-aciek wants to merge 15 commits into
Open
gh-56634: Gettext: raise descriptive ValueErrors instead of IndexErrors for incorrect .mo files metadata#112895m-aciek wants to merge 15 commits into
ValueErrors instead of IndexErrors for incorrect .mo files metadata#112895m-aciek wants to merge 15 commits into
Conversation
m-aciek
force-pushed
the
gettext-handle-incorrect-plural-forms
branch
from
a2515c9 to
17baf50
Compare
m-aciek
changed the title
m-aciek
force-pushed
the
gettext-handle-incorrect-plural-forms
branch
from
17baf50 to
e38c34c
Compare
m-aciek
force-pushed
the
gettext-handle-incorrect-plural-forms
branch
from
e38c34c to
e148f83
Compare
michalbon
approved these changes
Feb 14, 2024
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
Could you please add similar change for content-type?
m-aciek
changed the title
.mo files metadata parsing
m-aciek
changed the title
.mo files metadata parsingValueErrors instead of IndexErrors for incorrect .mo files metadata
Contributor
Author
@serhiy-storchaka Would it be possible for you to find a spare moment for a re-review? Thank you! |
Contributor
Author
|
(Fixed Windows support in tests.) |
…ySiu.rst Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raising
ValueErrors with descriptive error messages."Plural-Forms: \n"(original downstream bug, and fix) but also lack ofplural=keyword, like"Plural-Forms: nplurals=4;\n".ValueError: expected ';' and 'plural=' in Plural-Forms metadata in sample.mo, got ''IndexErrorValueError: expected 'charset=' in Content-Type metadata in sample.mo, got ''IndexErrorIn the #56634 ignoring the incorrect syntax was being discussed, as well as issuing warnings.
The implementation here is following the suggestion of @serhiy-storchaka of raising an error instead.