Skip to content

bpo-35614: Fix pydoc help() on metaclasses#11357

Merged
ncoghlan merged 1 commit into
python:masterfrom
CuriousLearner:issue35614
Dec 31, 2018
Merged

bpo-35614: Fix pydoc help() on metaclasses#11357
ncoghlan merged 1 commit into
python:masterfrom
CuriousLearner:issue35614

Conversation

@CuriousLearner

@CuriousLearner CuriousLearner commented Dec 29, 2018

Copy link
Copy Markdown
Member

@merwok

merwok commented Dec 29, 2018

Copy link
Copy Markdown
Member

Would you mind adding tests?

@serhiy-storchaka

Copy link
Copy Markdown
Member

Just check that help(type) does not fail.

@CuriousLearner

Copy link
Copy Markdown
Member Author

@serhiy-storchaka @merwok Fixed. Can you please have a look now?

@merwok

merwok commented Dec 29, 2018

Copy link
Copy Markdown
Member

Can you confirm that ./python -m pydoc abc with your fix doesn’t error?

@CuriousLearner

Copy link
Copy Markdown
Member Author

@merwok I'm on mac, and for abc it shows me the doc.

@ncoghlan ncoghlan merged commit b539cef into python:master Dec 31, 2018
@bedevere-bot

Copy link
Copy Markdown

@ncoghlan: Please replace # with GH- in the commit message next time. Thanks!

@ncoghlan

Copy link
Copy Markdown
Contributor

Bleh, GitHub didn't accept my commit message edits, but then went ahead and merged the change anyway :(

csabella pushed a commit to csabella/cpython that referenced this pull request Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants