bpo-35598: IDLE: Refactor globals in config_key.py#11392
Merged
Conversation
* Move translate_key to module level * Move key tuples to module level
Separate load_final_key_list() is no longer needed after all but one of its lines are moved to global scope.
terryjreedy
approved these changes
Dec 31, 2018
terryjreedy
left a comment
terryjreedy
left a comment
Member
There was a problem hiding this comment.
This will make initial import slightly slower, repeated instantiations slightly faster, but maybe a millisecond either way. Removing the now unneeded function and its call makes the globalization look even more worthwhile.
Contributor
|
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-11393 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 31, 2018
Move translate_key() and constant tuples to module level. Inline the remnant one-line function. (cherry picked from commit b4ea8bb) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Dec 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35598