Skip to content

bpo-33987: IDLE: Use ttk Frame on help.py#11433

Merged
terryjreedy merged 2 commits into
python:masterfrom
csabella:frame
Oct 22, 2020
Merged

bpo-33987: IDLE: Use ttk Frame on help.py#11433
terryjreedy merged 2 commits into
python:masterfrom
csabella:frame

Conversation

@csabella

@csabella csabella commented Jan 4, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor
  • Convert help.py to ttk frame.
  • Use of ttk Style is similar to configdialog.py. Without having to introduce ttk styles and themes too much, this is basically a specific replacement to the old usage of background on Label.
  • I left off the blurb since I used the same ticket number. Since you did all the other screens under one ticket, I didn't know if you wanted to reuse that or create a new ticket for this.

https://bugs.python.org/issue33987

@csabella csabella requested a review from terryjreedy as a code owner January 4, 2019 23:50
terryjreedy
terryjreedy approved these changes Oct 22, 2020
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add a news item after also converting searchbase, as that will have a visible impact at least on macOS.

Comment thread Lib/idlelib/help.py
self.text = text = HelpText(self, filename)
self['background'] = text['background']
self.style = Style(parent)
self['style'] = 'helpframe.TFrame'

@terryjreedy terryjreedy Oct 22, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, the gray background for the menubutton extended down the entire length of the window. I prefer the current box just around [TOC V].

@terryjreedy terryjreedy merged commit facb522 into python:master Oct 22, 2020
@miss-islington

miss-islington commented Oct 22, 2020

Copy link
Copy Markdown
Contributor

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2020
@csabella @miss-islington
bpo-33987: IDLE: Use ttk Frame on doc window and statusbar (pythonGH-…
3363b95 
…11433)

(cherry picked from commit facb522)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot

bedevere-bot commented Oct 22, 2020

Copy link
Copy Markdown

GH-22899 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2020
@csabella @miss-islington
bpo-33987: IDLE: Use ttk Frame on doc window and statusbar (pythonGH-…
ae58210 
…11433)

(cherry picked from commit facb522)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot

bedevere-bot commented Oct 22, 2020

Copy link
Copy Markdown

GH-22900 is a backport of this pull request to the 3.8 branch.

terryjreedy pushed a commit that referenced this pull request Oct 22, 2020
@miss-islington @csabella
bpo-33987: IDLE: Use ttk Frame on doc window and statusbar (GH-11433) (…
25687bb 
…GH-22899)

(cherry picked from commit facb522)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
terryjreedy pushed a commit that referenced this pull request Oct 22, 2020
@miss-islington @csabella
bpo-33987: IDLE: Use ttk Frame on doc window and statusbar (GH-11433) (…
06c9e01 
…GH-22900)

(cherry picked from commit facb522)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@csabella csabella deleted the frame branch October 23, 2020 12:29
@csabella

csabella commented Oct 23, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing and merging this! :-)

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@csabella @adorilson
bpo-33987: IDLE: Use ttk Frame on doc window and statusbar (pythonGH-…
a45225c 
…11433)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@csabella @miss-islington @bedevere-bot @terryjreedy @the-knights-who-say-ni