Skip to content

bpo-35717: Fix KeyError exception raised when using enums and compile#11523

Merged
miss-islington merged 3 commits into
python:masterfrom
remilapeyre:enum.Enum-error-on-sys._getframe
Jan 24, 2019
Merged

bpo-35717: Fix KeyError exception raised when using enums and compile#11523
miss-islington merged 3 commits into
python:masterfrom
remilapeyre:enum.Enum-error-on-sys._getframe

Conversation

@remilapeyre

@remilapeyre remilapeyre commented Jan 11, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown

@remilapeyre remilapeyre changed the title bpo-17467: Fix KeyError exception raised when using enums and compile bpo-35717: Fix KeyError exception raised when using enums and compile Jan 11, 2019
vstinner
vstinner reviewed Jan 11, 2019
View reviewed changes
Comment thread Lib/test/test_enum.py Outdated
@ethanfurman ethanfurman self-assigned this Jan 11, 2019
ethanfurman
ethanfurman requested changes Jan 11, 2019
View reviewed changes
Comment thread Lib/test/test_enum.py Outdated
@bedevere-bot

bedevere-bot commented Jan 11, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@remilapeyre

remilapeyre commented Jan 11, 2019

Copy link
Copy Markdown
Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jan 11, 2019

Copy link
Copy Markdown

Thanks for making the requested changes!

@ethanfurman: please review the changes made to this pull request.

ethanfurman
ethanfurman requested changes Jan 11, 2019
View reviewed changes

@ethanfurman ethanfurman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Now add yourself to Misc/ACKS. :)

@bedevere-bot

bedevere-bot commented Jan 11, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@remilapeyre

remilapeyre commented Jan 11, 2019

Copy link
Copy Markdown
Author

Thanks @ethanfurman, I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Jan 11, 2019

Copy link
Copy Markdown

Thanks for making the requested changes!

@ethanfurman: please review the changes made to this pull request.

@ethanfurman

ethanfurman commented Jan 20, 2019

Copy link
Copy Markdown
Member

Thank you. As soon as I get this on my machine for final checks I'll move it forward. :)

@vstinner

vstinner commented Jan 21, 2019

Copy link
Copy Markdown
Member

Now add yourself to Misc/ACKS. :)

Honestly, I don't think that it it's still important since we moved to Git: the author is know tracked in Git.

Note: There is a "thanks.python.org" project similar to https://thanks.rust-lang.org/ cc @pablogsal

@pablogsal

pablogsal commented Jan 21, 2019

Copy link
Copy Markdown
Member

Note: There is a "thanks.python.org" project similar to https://thanks.rust-lang.org/ cc @pablogsal

Sadly, it was cancelled as in the core dev sprint it was decided not worth the maintenance cost.

@miss-islington miss-islington merged commit 1fd06f1 into python:master Jan 24, 2019
@miss-islington

miss-islington commented Jan 24, 2019

Copy link
Copy Markdown
Contributor

Thanks @remilapeyre for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 24, 2019
@miss-islington
bpo-35717: Fix KeyError exception raised when using enums and compile (…
0780c4c 
…pythonGH-11523)

https://bugs.python.org/issue17467
(cherry picked from commit 1fd06f1)

Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
@bedevere-bot

bedevere-bot commented Jan 24, 2019

Copy link
Copy Markdown

GH-11669 is a backport of this pull request to the 3.7 branch.

vstinner pushed a commit that referenced this pull request Jan 30, 2019
@miss-islington @vstinner
bpo-35717: Fix KeyError exception raised when using enums and compile (…
1c79891 
…GH-11523) (GH-11669)

https://bugs.python.org/issue17467
(cherry picked from commit 1fd06f1)

Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@ethanfurman ethanfurman ethanfurman approved these changes

Assignees

@ethanfurman ethanfurman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@remilapeyre @bedevere-bot @ethanfurman @vstinner @pablogsal @miss-islington @serhiy-storchaka @the-knights-who-say-ni