bpo-35758: Fix building on ARM + MSVC#11531
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
eamanu
left a comment
eamanu
left a comment
There was a problem hiding this comment.
You must sign CLA and add NEWS. Maybe this PR need more discuss. I recommend open a new bpo or send some comments to the issue to activate it.
|
I'll file a new bug about this. Thanks. |
gongminmin
changed the title
|
CLA signed, and a new bug 35758 is filed for disabling x87 on ARM. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
On msvc, x87 control word is only available on x86 target. Need to disable it for other targets to prevent compiling problems.
|
I found another problem about arm. In Include\internal\pycore_atomic.h, immintrin.h should only be included on x86 and x64. Should I fix it in this PR or open another one? Thanks. |
|
I have made the requested changes; please review again. And also add an entry in Misc/News.d/next. |
|
Thanks for making the requested changes! @pitrou: please review the changes made to this pull request. |
You can fix it in this PR. |
Immintrin.h is only available on x86 and x64. Need to disable it for other targets to prevent compiling problems.
|
Thanks @gongminmin. Is this sufficient to get Python to compile and run on ARM + MVSC? If so, I think we can merge soon. |
pitrou
changed the title
pitrou
changed the title
|
Yes, with this change, I can build arm and arm64 pythoncore and most modules. |
|
Perfect, will merge then ;-) |
|
Thanks very much! |
* Disable x87 control word for non-x86 targets On msvc, x87 control word is only available on x86 target. Need to disable it for other targets to prevent compiling problems. * Include immintrin.h on x86 and x64 only Immintrin.h is only available on x86 and x64. Need to disable it for other targets to prevent compiling problems.
5 participants
Msvc defines _M_ARM for arm target, but it doesn't have x87 control word. Need to disable it to prevent some compiling problems.
https://bugs.python.org/issue14802