bpo-36682: rename duplicate functions#12895
Merged
Merged
Conversation
eamanu
suggested changes
Apr 22, 2019
eamanu
left a comment
eamanu
left a comment
Contributor
There was a problem hiding this comment.
Hello! IMO This aren't a duplicate functions issue. The first method is about there are not arguments.
The second method is for invalid arguments.
Furthermore, the name are not equal test_unbound_method_no_args != test_unbound_method_invalid_args
Contributor
Author
|
@eamanu You may have a look at test_sys_setprofile.py, there are two |
Contributor
|
Oh yes, I see that. Good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename duplicate functions
https://bugs.python.org/issue36682