bpo-26143: IDLE: Ensure IDLE's stdlib imports are from the stdlib#1364
bpo-26143: IDLE: Ensure IDLE's stdlib imports are from the stdlib#1364louisom wants to merge 3 commits into
Conversation
Add idlelib.importpath._fix_import_path function to handle local import problem. The local import path will be recover when at the end of the argparse part.
|
@lulouie, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbkaiser, @terryjreedy and @ned-deily to be potential reviewers. |
louisom
changed the title
|
Since this pull request is from an unknown repository, I'm going to close this. A new pull request can be opened for the bug ticket. |
@csabella: Is that a documented constraint in our workflow? IIUC, the only thing we need is the CLA, which seems to have been signed here, so there should be no legal problems here. |
|
@erlend-aasland OP switched to another account for cpython contributions and deleted the python fork on this account, orphaning this PR. I believe you are correct that we could still merge as is or with edits through the web interface. However, we cannot push changes to an 'unknown' (non-existent) repository. This PR would need this for changes that cannot be done through the web or that would need local testing. Adding a new idlelib module and test module for one trivial function is wrong. (I believe that this was Louie's first contribution.) The hard part of this issue is restoring '' to path when needed. This does not do so, in spite of the claim above otherwise. I commented further on the issue, but don't remember looking at the tests in detail, although there might be something usable there. |
7 participants
Add idlelib.importpath._fix_import_path function to handle
local import problem. The local import path will be recover
when at the end of the argparse part.