Skip to content

bpo-22807: Expose platform UUID generation safety information. #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
warsaw merged 12 commits into from
Feb 18, 2017
Merged

bpo-22807: Expose platform UUID generation safety information. #138

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bbdef4c
bpo-22807: Expose platform UUID generation safety information.
warsaw Feb 16, 2017
ccefb3a
pragma-fy some lines that are okay not to get covered.
warsaw Feb 16, 2017
9040ce0
Make is_safe a keyword argument.
warsaw Feb 17, 2017
440f560
Oops, fix indentation.
warsaw Feb 17, 2017
1b3d88e
Make devguide link in README more prominent (#145)
ncoghlan Feb 18, 2017
ace5c0f
bpo-29571: Use correct locale encoding in test_re (#149)
ncoghlan Feb 18, 2017
7787df6
bpo-22807: Expose platform UUID generation safety information.
warsaw Feb 16, 2017
27753e2
pragma-fy some lines that are okay not to get covered.
warsaw Feb 16, 2017
c898201
Make is_safe a keyword argument.
warsaw Feb 17, 2017
fb3088a
Oops, fix indentation.
warsaw Feb 17, 2017
4956e88
Merge branch 'bpo-22807' of github.com:warsaw/cpython into bpo-22807
warsaw Feb 18, 2017
7b29c47
Respond to review
warsaw Feb 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pragma-fy some lines that are okay not to get covered.
  • Loading branch information
@warsaw
warsaw committed Feb 16, 2017
commit ccefb3ad7aa89d59ab8abf881171367b375a94de
4 changes: 2 additions & 2 deletions Lib/uuid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,14 +487,14 @@ def _netbios_getnode():
for libname in _libnames:
try:
lib = ctypes.CDLL(ctypes.util.find_library(libname))
except Exception:
except Exception: # pragma: nocover
continue
# Try to find the safe variety first.
if hasattr(lib, 'uuid_generate_time_safe'):
_uuid_generate_time = lib.uuid_generate_time_safe
# int uuid_generate_time_safe(uuid_t out);
break
elif hasattr(lib, 'uuid_generate_time'):
elif hasattr(lib, 'uuid_generate_time'): # pragma: nocover
_uuid_generate_time = lib.uuid_generate_time
# void uuid_generate_time(uuid_t out);
_uuid_generate_time.restype = None
Expand Down