Skip to content

bpo-37261: Fix support.catch_unraisable_exception()#14052

Merged
vstinner merged 3 commits into
python:masterfrom
vstinner:fix_catch_unraisable
Jun 13, 2019
Merged

bpo-37261: Fix support.catch_unraisable_exception()#14052
vstinner merged 3 commits into
python:masterfrom
vstinner:fix_catch_unraisable

Conversation

@vstinner

@vstinner vstinner commented Jun 13, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

The exit() method of test.support.catch_unraisable_exception
context manager now ignores unraisable exception raised when clearing
self.unraisable attribute.

https://bugs.python.org/issue37261

@vstinner
bpo-37261: Fix support.catch_unraisable_exception()
74ca0d1 
The __exit__() method of test.support.catch_unraisable_exception
context manager now ignores unraisable exception raised when clearing
self.unraisable attribute.
tirkarthi
tirkarthi reviewed Jun 13, 2019
View reviewed changes

@tirkarthi tirkarthi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo suggestions. Is this worth updating Doc/library/test.rst too?

Comment thread Lib/test/support/__init__.py Outdated
Comment thread Lib/test/support/__init__.py Outdated
Comment thread Lib/test/support/__init__.py Outdated
@vstinner

vstinner commented Jun 13, 2019

Copy link
Copy Markdown
Member Author

Minor typo suggestions. Is this worth updating Doc/library/test.rst too?

Done. Thanks for the review ;-)

@vstinner

vstinner commented Jun 13, 2019

Copy link
Copy Markdown
Member Author

@tirkarthi: Would you mind to review my update PR?

tirkarthi
tirkarthi approved these changes Jun 13, 2019
View reviewed changes

@tirkarthi tirkarthi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor typo in code comment that is same as doc change to use resurrect. Doc changes look good to me. Thanks.

Comment thread Lib/test/support/__init__.py Outdated
@vstinner @tirkarthi
Update Lib/test/support/__init__.py
20f3cd1 
Co-Authored-By: Xtreak <tir.karthi@gmail.com>
@vstinner vstinner merged commit 6d22cc8 into python:master Jun 13, 2019
@miss-islington

miss-islington commented Jun 13, 2019

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jun 13, 2019

Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@vstinner vstinner deleted the fix_catch_unraisable branch June 13, 2019 12:45
@miss-islington

miss-islington commented Jun 13, 2019

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 13, 2019
@vstinner @miss-islington
bpo-37261: Fix support.catch_unraisable_exception() (pythonGH-14052)
d13a770 
The __exit__() method of test.support.catch_unraisable_exception
context manager now ignores unraisable exception raised when clearing
self.unraisable attribute.
(cherry picked from commit 6d22cc8)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@bedevere-bot

bedevere-bot commented Jun 13, 2019

Copy link
Copy Markdown

GH-14056 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jun 13, 2019
@miss-islington @vstinner
bpo-37261: Fix support.catch_unraisable_exception() (GH-14052)
b4f5b21 
The __exit__() method of test.support.catch_unraisable_exception
context manager now ignores unraisable exception raised when clearing
self.unraisable attribute.
(cherry picked from commit 6d22cc8)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@vstinner @lisroach
bpo-37261: Fix support.catch_unraisable_exception() (pythonGH-14052)
a039b24 
The __exit__() method of test.support.catch_unraisable_exception
context manager now ignores unraisable exception raised when clearing
self.unraisable attribute.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@vstinner @DinoV
bpo-37261: Fix support.catch_unraisable_exception() (pythonGH-14052)
32614b9 
The __exit__() method of test.support.catch_unraisable_exception
context manager now ignores unraisable exception raised when clearing
self.unraisable attribute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @miss-islington @bedevere-bot @tirkarthi @the-knights-who-say-ni