Skip to content

gh-146256: Add --jsonl collector to the profiling.sampling #146257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 41 commits into from
May 5, 2026
Merged

gh-146256: Add --jsonl collector to the profiling.sampling #146257

Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
65312d5
first stab
maurycy Mar 21, 2026
dff2ead
s/ndjson/jsonl/
maurycy Mar 21, 2026
23b5df1
printing to stdout isn't a great idea
maurycy Mar 22, 2026
9cdb971
even a basic test
maurycy Mar 30, 2026
5920559
separate func for end record
maurycy Mar 30, 2026
28ebd2a
proper name
maurycy Mar 30, 2026
bc3370b
test_jsonl_collector_with_location_info
maurycy Mar 31, 2026
a151578
test synthetic frames
maurycy Mar 31, 2026
f851de9
too many new lines
maurycy Mar 31, 2026
e5831a8
BUG? confusing... two ways to set skip_idle?
maurycy Mar 31, 2026
9c106a4
ok, thx b4fac15613a16f9cd7b2ee32840523b399f4621f
maurycy Mar 31, 2026
727f05f
check if it works fine with (file, loc, func, op)
maurycy Mar 31, 2026
1c6f81a
missing new line
maurycy Mar 31, 2026
c278f83
filter out sync coordinator
maurycy Mar 31, 2026
bf6b454
s/collapsed_out/jsonl_out/, less copying :D
maurycy Mar 31, 2026
9ef96f8
nicer reading
maurycy Mar 31, 2026
13dd0f2
typo
maurycy Mar 31, 2026
ae7afe1
too much copying, left-over
maurycy Mar 31, 2026
a8eb46d
just Counter
maurycy Mar 31, 2026
9982bb4
ruff
maurycy Mar 31, 2026
fe29888
future-proof name
maurycy Mar 31, 2026
a5192b7
future-proof iter for streaming
maurycy Mar 31, 2026
1d53e16
truth to be told, this should be layer above
maurycy Mar 31, 2026
4b477c0
helper
maurycy Mar 31, 2026
e14f6f1
reorder
maurycy Mar 31, 2026
cf6aa9e
eh, just copy from heatmap
maurycy Mar 31, 2026
1f4c766
smaller chunk; matter of taste
maurycy Mar 31, 2026
ba5712e
test actual chunking
maurycy Mar 31, 2026
3cacc30
test edge cases
maurycy Mar 31, 2026
4d48f58
ruff
maurycy Mar 31, 2026
3ea253b
match pep8
maurycy Mar 31, 2026
308ca86
style
maurycy Mar 31, 2026
0db38a1
too defensive
maurycy Mar 31, 2026
4c768b4
too many style changes
maurycy Mar 31, 2026
5e86f4f
less style
maurycy Mar 31, 2026
25eb558
ha! even less style...
maurycy Mar 31, 2026
d25b4d5
news
maurycy Mar 31, 2026
0c0089a
news: proper formatting
maurycy Mar 31, 2026
5690ddf
claim credit!
maurycy Apr 4, 2026
8e1d83b
fixup! claim credit!
pablogsal May 4, 2026
fb4a7c8
fixup! fixup! claim credit!
pablogsal May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
too much copying, left-over
  • Loading branch information
@maurycy @pablogsal
maurycy authored and pablogsal committed May 5, 2026
commit ae7afe1fa4ddb415ead8dc11833cb7dbcb84ad3e
5 changes: 0 additions & 5 deletions Lib/test/test_profiling/test_sampling_profiler/test_modes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,11 +371,6 @@ def jsonl(obj):
for exp in expected:
self.assertIn(exp, lines)

# self.assertIn(active1_key, collector_no_skip.result)
# self.assertIn(active2_key, collector_no_skip.result)
# self.assertIn(
# idle_key, collector_no_skip.result
# ) # Idle thread should be included

@requires_remote_subprocess_debugging()
class TestGilModeFiltering(unittest.TestCase):
Expand Down