bpo-18374: fix tests to check the correct thing about line numbers#14659
Merged
ilevkivskyi merged 1 commit intoJul 9, 2019
Conversation
Contributor
|
Thanks @cfbolz for the PR, and @ilevkivskyi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 9, 2019
…ythonGH-14659) (cherry picked from commit 430a9f4) Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
|
GH-14672 is a backport of this pull request to the 3.8 branch. |
Member
I don't think it is worth spending some manual work on the backport. Fixing it in 3.8 is already good enough. |
ilevkivskyi
pushed a commit
that referenced
this pull request
Jul 9, 2019
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ilevkivskyi here's the promised fix.
Should I also try to do the backport to 3.7? (the automated merging fails because the
end_linenoandend_col_offsetdidn't exist in 3.7).https://bugs.python.org/issue18374