Skip to content

GH-148726: Add heap_size to generational GC #149195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 11 commits into from
May 4, 2026
Merged

GH-148726: Add heap_size to generational GC #149195

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b6ec992
Add heap_size to _gc_runtime_state
sergey-miryanov Apr 26, 2026
2281499
Add heap_size to stats
sergey-miryanov Apr 30, 2026
704e94e
Heap size should be added at end of the struct
sergey-miryanov May 3, 2026
83953c5
Move heap_size to the end of the gc_generation_stats struct
sergey-miryanov May 3, 2026
da497d1
Merge branch 'main' into feat/gc-gen-3.15+heap_size
sergey-miryanov May 3, 2026
fd93679
Add heap_size to get_gc_stats
sergey-miryanov May 3, 2026
344f32c
Make AC happy
sergey-miryanov May 3, 2026
8a3a862
Merge branch 'main' into feat/gc-gen-3.15+heap_size
sergey-miryanov May 4, 2026
014d98a
Remove dummy members
sergey-miryanov May 4, 2026
e268637
Merge branch 'feat/gc-gen-3.15+heap_size' of github.com:sergey-miryan…
sergey-miryanov May 4, 2026
7ba65db
Remove extra line
sergey-miryanov May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add heap_size to stats
  • Loading branch information
@sergey-miryanov
sergey-miryanov committed Apr 30, 2026
commit 22814995137104f04ed1a58e5ca16f669cda18b3
2 changes: 2 additions & 0 deletions Include/internal/pycore_interp_structs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,8 @@ struct gc_generation {
struct gc_generation_stats {
PyTime_t ts_start;
PyTime_t ts_stop;
/* heap_size on the start of the collection */
Py_ssize_t heap_size;
/* total number of collections */
Py_ssize_t collections;
/* total number of collected objects */
Expand Down
4 changes: 3 additions & 1 deletion Python/gc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1405,14 +1405,15 @@ add_stats(GCState *gcstate, int gen, struct gc_generation_stats *stats)
memcpy(cur_stats, prev_stats, sizeof(struct gc_generation_stats));

cur_stats->ts_start = stats->ts_start;
cur_stats->ts_stop = stats->ts_stop;
cur_stats->heap_size = stats->heap_size;

cur_stats->collections += 1;
cur_stats->collected += stats->collected;
cur_stats->uncollectable += stats->uncollectable;
cur_stats->candidates += stats->candidates;

cur_stats->duration += stats->duration;
cur_stats->ts_stop = stats->ts_stop;
}

/* This is the main function. Read this to understand how the
Expand Down Expand Up @@ -1465,6 +1466,7 @@ gc_collect_main(PyThreadState *tstate, int generation, _PyGC_Reason reason)
invoke_gc_callback(tstate, "start", generation, &stats);
}

stats.heap_size = gcstate->heap_size;
// ignore error: don't interrupt the GC if reading the clock fails
(void)PyTime_PerfCounterRaw(&stats.ts_start);
if (gcstate->debug & _PyGC_DEBUG_STATS) {
Expand Down
Loading