bpo-32178: Fix IndexError trying to parse 'To' header starting with ':'.#15044
Merged
Conversation
Member
|
I will review this. |
matrixise
reviewed
Aug 1, 2019
| if x.token_type == 'quoted-string': | ||
| quote = True | ||
| if quote: | ||
| if self and quote: |
Member
There was a problem hiding this comment.
in which case, self would be None|False|0?
Contributor
Author
There was a problem hiding this comment.
I think it should be len(self) != 0 for being more explicit, like in the method above, I'll make the changes.
This would be when the TokenList is empty with no tokens.
CuriousLearner
left a comment
CuriousLearner
left a comment
Member
There was a problem hiding this comment.
Overall looks good. Just one more minor suggestion. Please find my suggestion inline.
Co-Authored-By: Sanyam Khurana <8039608+CuriousLearner@users.noreply.github.com>
CuriousLearner
left a comment
CuriousLearner
left a comment
Member
There was a problem hiding this comment.
You may re-run the Travis tests and they should pass. Just one more nit-pick.
Overall LGTM 🌮 💯
Contributor
|
Thanks @maxking for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 11, 2019
…:'. (pythonGH-15044) This should fix the IndexError trying to retrieve `DisplayName.display_name` and `DisplayName.value` when the `value` is basically an empty string. https://bugs.python.org/issue32178 (cherry picked from commit 09a1872) Co-authored-by: Abhilash Raj <maxking@users.noreply.github.com>
|
GH-15213 is a backport of this pull request to the 3.8 branch. |
|
GH-15214 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 11, 2019
…:'. (pythonGH-15044) This should fix the IndexError trying to retrieve `DisplayName.display_name` and `DisplayName.value` when the `value` is basically an empty string. https://bugs.python.org/issue32178 (cherry picked from commit 09a1872) Co-authored-by: Abhilash Raj <maxking@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Aug 11, 2019
…:'. (GH-15044) This should fix the IndexError trying to retrieve `DisplayName.display_name` and `DisplayName.value` when the `value` is basically an empty string. https://bugs.python.org/issue32178 (cherry picked from commit 09a1872) Co-authored-by: Abhilash Raj <maxking@users.noreply.github.com>
miss-islington
added a commit
that referenced
this pull request
Aug 11, 2019
…:'. (GH-15044) This should fix the IndexError trying to retrieve `DisplayName.display_name` and `DisplayName.value` when the `value` is basically an empty string. https://bugs.python.org/issue32178 (cherry picked from commit 09a1872) Co-authored-by: Abhilash Raj <maxking@users.noreply.github.com>
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
…:'. (pythonGH-15044) This should fix the IndexError trying to retrieve `DisplayName.display_name` and `DisplayName.value` when the `value` is basically an empty string. https://bugs.python.org/issue32178
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…:'. (pythonGH-15044) This should fix the IndexError trying to retrieve `DisplayName.display_name` and `DisplayName.value` when the `value` is basically an empty string. https://bugs.python.org/issue32178
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
…:'. (pythonGH-15044) This should fix the IndexError trying to retrieve `DisplayName.display_name` and `DisplayName.value` when the `value` is basically an empty string. https://bugs.python.org/issue32178
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the IndexError trying to retrieve
DisplayName.display_nameandDisplayName.valuewhen thevalueis basically an empty string.https://bugs.python.org/issue32178
Automerge-Triggered-By: @maxking