bpo-34880: assert statement misbehavior if AssertionError is shadowed#15073
Merged
serhiy-storchaka merged 7 commits intoAug 25, 2019
Merged
Conversation
Member
|
I'd like to keep any new bytecodes as simple as possible. The simplest I can think of is a |
Member
|
I concur with @markshannon. There is no benefit from implementing it as a single bytecode: it is neither performance critical nor should be atomical. Using |
Contributor
Author
|
Thanks for all of the comments. I have implemented |
ZackerySpytz
commented
Aug 13, 2019
fusioncid
reviewed
Aug 20, 2019
fusioncid
left a comment
fusioncid
left a comment
Contributor
There was a problem hiding this comment.
It's better for "{" at the end of the previous line.
…onError-shadowing-assert
Contributor
Author
serhiy-storchaka
approved these changes
Aug 22, 2019
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
LGTM, but it needs to wait until #15320 be merged.
Contributor
serhiy-storchaka
approved these changes
Aug 25, 2019
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
Fix assert statement misbehavior if AssertionError is shadowed.
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
Fix assert statement misbehavior if AssertionError is shadowed.
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
Fix assert statement misbehavior if AssertionError is shadowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assert statement was not working properly if the AssertionError
exception was being shadowed.
https://bugs.python.org/issue34880