bpo-1047397: prevent repr/getattr exceptions in cgitb#15094
Closed
RMJ10 wants to merge 5 commits into
Closed
Conversation
ethanfurman
reviewed
Aug 13, 2019
ethanfurman
left a comment
ethanfurman
left a comment
Member
There was a problem hiding this comment.
We need a news entry (see the blurb tool).
Also, some tests would be good .
| return self.failval | ||
|
|
||
| def _pydoc_repr(value, sub='html'): | ||
| return getattr(pydoc, 'html').repr(value) |
Member
There was a problem hiding this comment.
Should 'html' be sub instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Robin Becker's patch, slightly tweaked (for rotting) and tidied. Basically it wraps calls to getattr and repr while inspecting the code for which the traceback is being generated to prevent them from causing more exceptions.
https://bugs.python.org/issue1047397