Skip to content

gh-152785: Upgrade GCC from 10 to 13 in GHA Address Sanitizer#152782

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:asan_gcc10
Jul 2, 2026
Merged

gh-152785: Upgrade GCC from 10 to 13 in GHA Address Sanitizer#152782
vstinner merged 1 commit into
python:mainfrom
vstinner:asan_gcc10

Conversation

@vstinner

@vstinner vstinner commented Jul 1, 2026

Copy link
Copy Markdown
Member

Remove the step which installs GCC 10. This step was needed when Ubuntu only had GCC 9. We are now using Ubuntu 24.04 which has GCC 13.2.

Remove the step which installs GCC 10. This step was needed when
Ubuntu only had GCC 9. We are now using Ubuntu 24.04 which has GCC
13.2.
@vstinner vstinner changed the title Upgrade GCC from 10 to 13.2 in GHA Address Sanitizer gh-152785: Upgrade GCC from 10 to 13.2 in GHA Address Sanitizer Jul 1, 2026
@vstinner vstinner changed the title gh-152785: Upgrade GCC from 10 to 13.2 in GHA Address Sanitizer gh-152785: Upgrade GCC from 10 to 13 in GHA Address Sanitizer Jul 1, 2026
@vstinner vstinner marked this pull request as ready for review July 1, 2026 13:11
@vstinner

vstinner commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

The "Address sanitizer (ubuntu-24.04)" job completed successfully with GCC 13.3.0.

@vstinner

vstinner commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

@corona10: Would you mind reviewing this change?

IMO it's a good thing to use newer GCC version. It should catch more errors and produce less false alarms.

The GCC-10 step was added in 2023 by issue gh-103726: commit 8330580 (PR gh-103728). In 2023, Ubuntu provided GCC 9.

@vstinner

vstinner commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

Before, test.pythoninfo:

CC.version: gcc (Ubuntu 10.5.0-4ubuntu2.1) 10.5.0

After, test.pythoninfo:

CC.version: gcc (Ubuntu 13.3.0-6ubuntu2~24.04.1) 13.3.0

@vstinner vstinner merged commit 31a0e09 into python:main Jul 2, 2026
56 checks passed
@vstinner vstinner deleted the asan_gcc10 branch July 2, 2026 14:52
@hugovk

hugovk commented Jul 2, 2026

Copy link
Copy Markdown
Member

How far can we backport this? We need to keep the CI running until branch EOL, and it's easier to maintain if we the branches are more similar to each other.

@vstinner vstinner added needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 3, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jul 3, 2026

Copy link
Copy Markdown

GH-152948 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 3, 2026
@bedevere-app

bedevere-app Bot commented Jul 3, 2026

Copy link
Copy Markdown

GH-152949 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 3, 2026
@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Jul 3, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jul 3, 2026

Copy link
Copy Markdown

GH-152950 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 3, 2026
@vstinner

vstinner commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

How far can we backport this? We need to keep the CI running until branch EOL, and it's easier to maintain if we the branches are more similar to each other.

Oh ok. I backported the change to 3.13, 3.14 and 3.15 branches.

The Java version upgrade #152783 was also backported to these branches.

vstinner added a commit that referenced this pull request Jul 3, 2026
…H-152782) (#152950)

gh-152785: Upgrade GCC from 10 to 13 in GHA Address Sanitizer (GH-152782)

Remove the step which installs GCC 10. This step was needed when
Ubuntu only had GCC 9. We are now using Ubuntu 24.04 which has GCC
13.
(cherry picked from commit 31a0e09)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Jul 3, 2026
…H-152782) (#152948)

gh-152785: Upgrade GCC from 10 to 13 in GHA Address Sanitizer (GH-152782)

Remove the step which installs GCC 10. This step was needed when
Ubuntu only had GCC 9. We are now using Ubuntu 24.04 which has GCC
13.
(cherry picked from commit 31a0e09)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Jul 3, 2026
…H-152782) (#152949)

gh-152785: Upgrade GCC from 10 to 13 in GHA Address Sanitizer (GH-152782)

Remove the step which installs GCC 10. This step was needed when
Ubuntu only had GCC 9. We are now using Ubuntu 24.04 which has GCC
13.
(cherry picked from commit 31a0e09)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants