Skip to content

gh-152903: Change PCWSTR to PWSTR in GetThreadDescription() typedef#152904

Merged
vstinner merged 1 commit into
python:mainfrom
carlo-bramini:fix-windows-bug-1
Jul 3, 2026
Merged

gh-152903: Change PCWSTR to PWSTR in GetThreadDescription() typedef#152904
vstinner merged 1 commit into
python:mainfrom
carlo-bramini:fix-windows-bug-1

Conversation

@carlo-bramini

@carlo-bramini carlo-bramini commented Jul 2, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app bedevere-app Bot mentioned this pull request Jul 2, 2026
Closed
StanFromIreland
StanFromIreland reviewed Jul 2, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also duplicated in:

cpython/Modules/_threadmodule.c

Line 78 in 31864bd

typedef HRESULT (WINAPI *PF_SET_THREAD_DESCRIPTION)(HANDLE, PCWSTR);

I think we should merge these by putting them in an internal header, but maybe that's better left to a follow up. CC @vstinner

@StanFromIreland StanFromIreland requested a review from vstinner July 2, 2026 18:27
@carlo-bramini

carlo-bramini commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

This is also duplicated in:

cpython/Modules/_threadmodule.c

Line 78 in 31864bd

typedef HRESULT (WINAPI *PF_SET_THREAD_DESCRIPTION)(HANDLE, PCWSTR);

Thank you very much.
I updated the patch according to your report.

vstinner
vstinner approved these changes Jul 3, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@vstinner vstinner added skip news needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 3, 2026
@vstinner

vstinner commented Jul 3, 2026

Copy link
Copy Markdown
Member

I think we should merge these by putting them in an internal header, but maybe that's better left to a follow up. CC @vstinner

I would prefer to not add it to an internal header file.

@vstinner vstinner merged commit ac1acb6 into python:main Jul 3, 2026
61 checks passed
@miss-islington-app

miss-islington-app Bot commented Jul 3, 2026

Copy link
Copy Markdown

Thanks @carlo-bramini for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-app

bedevere-app Bot commented Jul 3, 2026

Copy link
Copy Markdown

GH-152943 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 3, 2026
@bedevere-app

bedevere-app Bot commented Jul 3, 2026

Copy link
Copy Markdown

GH-152944 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 3, 2026
vstinner pushed a commit that referenced this pull request Jul 3, 2026
@miss-islington @carlo-bramini
[3.15] gh-152903: Change PCWSTR to PWSTR in GetThreadDescription() ty…
fe23aba 
…pedef (GH-152904) (#152943)

gh-152903: Change PCWSTR to PWSTR in GetThreadDescription() typedef (GH-152904)

Fixes issue GH-152903
(cherry picked from commit ac1acb6)

Co-authored-by: Carlo Bramini <carlo_bramini@users.sourceforge.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments
@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlo-bramini @vstinner @StanFromIreland