Skip to content

closes bpo-37964: add F_GETPATH command to fcntl#15550

Merged
miss-islington merged 4 commits into
python:masterfrom
vinay0410:fix-issue-37694
Aug 29, 2019
Merged

closes bpo-37964: add F_GETPATH command to fcntl#15550
miss-islington merged 4 commits into
python:masterfrom
vinay0410:fix-issue-37694

Conversation

@vinay0410

@vinay0410 vinay0410 commented Aug 27, 2019 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

benjaminp
benjaminp requested changes Aug 28, 2019
View reviewed changes

@benjaminp benjaminp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also a .. versionchanged directive about it to Doc/library/fcntl.rst.

@bedevere-bot

bedevere-bot commented Aug 28, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

@vinay0410

vinay0410 commented Aug 28, 2019

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again
I have also added a test, testing this command/flag on macos.

@bedevere-bot

bedevere-bot commented Aug 28, 2019

Copy link
Copy Markdown

Thanks for making the requested changes!

@benjaminp: please review the changes made to this pull request.

@benjaminp benjaminp changed the title bpo-37964: add F_GETPATH command in fcntl module closes bpo-37964: add F_GETPATH command to fcntl Aug 29, 2019
@miss-islington

miss-islington commented Aug 29, 2019

Copy link
Copy Markdown
Contributor

@vinay0410: Status check is done, and it's a failure ❌ .

2 similar comments
@miss-islington

miss-islington commented Aug 29, 2019

Copy link
Copy Markdown
Contributor

@vinay0410: Status check is done, and it's a failure ❌ .

@miss-islington

miss-islington commented Aug 29, 2019

Copy link
Copy Markdown
Contributor

@vinay0410: Status check is done, and it's a failure ❌ .

@miss-islington

miss-islington commented Aug 29, 2019

Copy link
Copy Markdown
Contributor

@vinay0410: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 13f37f2 into python:master Aug 29, 2019
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@vinay0410 @lisroach
closes bpo-37964: add F_GETPATH command to fcntl (pythonGH-15550)
c445575 
https://bugs.python.org/issue37964



Automerge-Triggered-By: @benjaminp
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@vinay0410 @DinoV
closes bpo-37964: add F_GETPATH command to fcntl (pythonGH-15550)
efb8042 
https://bugs.python.org/issue37964



Automerge-Triggered-By: @benjaminp
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@vinay0410 @websurfer5
closes bpo-37964: add F_GETPATH command to fcntl (pythonGH-15550)
a4b9126 
https://bugs.python.org/issue37964



Automerge-Triggered-By: @benjaminp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminp benjaminp benjaminp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vinay0410 @bedevere-bot @miss-islington @benjaminp @the-knights-who-say-ni