bpo-38116: Convert select module to PEP-384#15971
Merged
Merged
Conversation
Summary: Do the necessary versions to be Pyro-compatible, including migrating `PyType_Ready` to `PyType_FromSpec` and moving static data into a new `_selectstate` struct.
tiran
requested changes
Sep 11, 2019
tiran
left a comment
tiran
left a comment
Member
There was a problem hiding this comment.
macOS build fails:
gcc -Wno-unused-result -Wsign-compare -g -O0 -Wall -std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter -Wno-missing-field-initializers -Wstrict-prototypes -Werror=implicit-function-declaration -I./Include/internal -I./Include -I. -I/usr/local/include -I/Users/vsts/agent/2.155.1/work/1/s/Include -I/Users/vsts/agent/2.155.1/work/1/s -c /Users/vsts/agent/2.155.1/work/1/s/Modules/selectmodule.c -o build/temp.macosx-10.14-x86_64-3.9-pydebug/Users/vsts/agent/2.155.1/work/1/s/Modules/selectmodule.o
/Users/vsts/agent/2.155.1/work/1/s/Modules/selectmodule.c:1924:17: warning: initializing 'void *' with an expression of type 'const char [671]' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
{Py_tp_doc, kqueue_event_doc},
^~~~~~~~~~~~~~~~
In file included from /Users/vsts/agent/2.155.1/work/1/s/Modules/selectmodule.c:2274:
/Users/vsts/agent/2.155.1/work/1/s/Modules/clinic/selectmodule.c.h:962:19: error: use of undeclared identifier 'kqueue_queue_Type'
if ((type == &kqueue_queue_Type) &&
^
/Users/vsts/agent/2.155.1/work/1/s/Modules/clinic/selectmodule.c.h:966:19: error: use of undeclared identifier 'kqueue_queue_Type'
if ((type == &kqueue_queue_Type) &&
^
/Users/vsts/agent/2.155.1/work/1/s/Modules/selectmodule.c:2443:17: error: use of undeclared identifier 'kqueue_queue_doc'
{Py_tp_doc, kqueue_queue_doc},
^
/Users/vsts/agent/2.155.1/work/1/s/Modules/selectmodule.c:2446:17: error: use of undeclared identifier 'kqueue_queue_new'
{Py_tp_new, kqueue_queue_new},
^
1 warning and 4 errors generated.
|
When you're done making the requested changes, leave the comment: |
Contributor
Author
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @tiran: please review the changes made to this pull request. |
tiran
approved these changes
Sep 12, 2019
|
@DinoV: Please replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Do the necessary versions to be PEP-384 compatible , including migrating
PyType_ReadytoPyType_FromSpecand moving static data into a new_selectstatestruct.https://bugs.python.org/issue38116