bpo-37798: Prevent undefined behavior in direct calls to the C helper…#16149
Merged
Conversation
… function. While the _statistics helper is private and not intended to be called directly, it is possible to do so. That would bypass the parameter validation checks in the pure python calling code. Accordingly, we need to add parameter checks to avoid undefined behavior (division by zero) or errors in the underlying functions (negative square root or non-positive argument for logarithm).
rhettinger
added
type-bug
corona10
approved these changes
Sep 15, 2019
Member
There was a problem hiding this comment.
@rhettinger LGTM for the code.
2 questions for this PR.
-
Don't we have to add this logic for pure python version?
Line 821 in ff603f6
-
We don't need unit tests for _normal_dist_inv_cdf with error handling?
Member
|
@rhettinger |
|
@rhettinger: Please replace |
Contributor
|
Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-16160 is a backport of this pull request to the 3.8 branch. |
rhettinger
added a commit
that referenced
this pull request
Sep 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue37798