Skip to content

[3.8] bpo-37123: multiprocessing test_mymanager() accepts SIGTERM (GH-16349)#16352

Merged
miss-islington merged 1 commit into
python:3.8from
miss-islington:backport-b0e1ae5-3.8
Sep 24, 2019
Merged

[3.8] bpo-37123: multiprocessing test_mymanager() accepts SIGTERM (GH-16349)#16352
miss-islington merged 1 commit into
python:3.8from
miss-islington:backport-b0e1ae5-3.8

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 24, 2019

Copy link
Copy Markdown
Contributor

Multiprocessing test test_mymanager() now also expects -SIGTERM, not
only exitcode 0.

bpo-30356: BaseManager._finalize_manager() sends SIGTERM to the
manager process if it takes longer than 1 second to stop, which
happens on slow buildbots.
(cherry picked from commit b0e1ae5)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue37123

…-16349)

Multiprocessing test test_mymanager() now also expects -SIGTERM, not
only exitcode 0.

bpo-30356: BaseManager._finalize_manager() sends SIGTERM to the
manager process if it takes longer than 1 second to stop, which
happens on slow buildbots.
(cherry picked from commit b0e1ae5)

Co-authored-by: Victor Stinner <vstinner@redhat.com>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 081641f into python:3.8 Sep 24, 2019
@miss-islington miss-islington deleted the backport-b0e1ae5-3.8 branch September 24, 2019 12:39
@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants