gh-74606: Add fromfile_parent_relative parameter to argparse.ArgumentParser#1698
gh-74606: Add fromfile_parent_relative parameter to argparse.ArgumentParser#1698bob1de wants to merge 4 commits into
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
|
@efficiosoft, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @birkenfeld and @ezio-melotti to be potential reviewers. |
5cdac77 to
43a13d2
Compare
|
Ok, CLA is signed now and I'm ready for feedback. Best regards |
|
I wanted to ask for some progress on this issue. Is there somebody willing to review it? It still merges without conflicts. Best regards |
Ensure compatibility with upstream.
|
Adding a new parameter is an enhancement that has not been mentioned on the issue, let alone approved. |
|
Sorry, but what did you mean by "let alone approved"? Just for reference, here is a quote of the docs for the new parameter of
Best regards |
|
My comment (which constituted my review) was in response to that. You propose to add a new feature with a specific name. AFAIK, neither Bethard nor any other core developer has approved of either the new feature as a concept or the specific name. To seek such approval, you could post to python-ideas list. (I think most proposals other than for tkinter and IDLE should start there.) Briefly describe the idea and rationale and reference the issue and this PR. If you get a positive response, expect discussion of the option (parameter) name. |
|
Thank you for your explanation. This is my first contribution to cpython, hence thinks went a bit wrong somehow. |
|
@terryjreedy Ah! I didn't get your response at python-dev. That's why your comment here seemed out-of-context to me. Now I read it and things are clear. Thanks again! |
|
This PR is stale because it has been open for 30 days with no activity. |
|
Got issue testing so did a full test then got: 2 tests failed: [Irrelevant traceback of unrelelated failures delected by TJR.] |
|
This PR is stale because it has been open for 30 days with no activity. |
@terryjreedy Was the approval achieved? If not, should the PR and issue be closed then? /cc @bob1de |
|
@arhadthedev No, this wasn't pursued any further from my side. It started as the sharing of a little code I used in a project and thought could also be beneficial to stdlib, but the process turned out more complex than expected. Had not much of an idea of the cpython contribution guidelines back then. So I guess I'm better closing this right away and maybe start a fresh python-dev discussion on the issue eventually, correct? |
|
When this was submitted, the then expert listed in the expert's index was added as nosy, but he had become inactive. Another core dev worked on argparse a bit a year or two ago, and is doing other things now. I believe someone else has touched argparse recently, but not listed himself as an expert responsible for the module. Robert, if you are withdrawing the suggestion, perhaps close this and the issue. But if you still think it a good idea, I would leave at least the issue, for the next person who looks as the Argparse issues list Argparse issues. |
|
@terryjreedy Thanks, then I'll close this PR and leave the issue open; I still think the way nested inclusion behaves right now can be irritating at least. Maybe someone picks up the idea later on or has an even better way to improve on this. |
This is an enhanced version of patch file on http://bugs.python.org/issue30421.
It maintains backwards compatibility and docs have been updated as well.
See that or gh issue below for description.