Skip to content

gh-74606: Add fromfile_parent_relative parameter to argparse.ArgumentParser#1698

Closed
bob1de wants to merge 4 commits into
python:mainfrom
bob1de:BPO-30421-argparse_fromfile_parent_relative
Closed

gh-74606: Add fromfile_parent_relative parameter to argparse.ArgumentParser#1698
bob1de wants to merge 4 commits into
python:mainfrom
bob1de:BPO-30421-argparse_fromfile_parent_relative

Conversation

@bob1de

@bob1de bob1de commented May 21, 2017

Copy link
Copy Markdown

This is an enhanced version of patch file on http://bugs.python.org/issue30421.

It maintains backwards compatibility and docs have been updated as well.
See that or gh issue below for description.

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@mention-bot

Copy link
Copy Markdown

@efficiosoft, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @birkenfeld and @ezio-melotti to be potential reviewers.

@bob1de bob1de changed the title BPO-30421: Added fromfile_parent_relative parameter + docs to argparse.ArgumentParser BPO-30421 Added fromfile_parent_relative parameter + docs to argparse.ArgumentParser May 21, 2017
@bob1de bob1de changed the title BPO-30421 Added fromfile_parent_relative parameter + docs to argparse.ArgumentParser bpo-30421: Added fromfile_parent_relative parameter + docs to argparse.ArgumentParser May 21, 2017
@bob1de bob1de force-pushed the BPO-30421-argparse_fromfile_parent_relative branch from 5cdac77 to 43a13d2 Compare May 24, 2017 09:50
@bob1de

bob1de commented May 24, 2017

Copy link
Copy Markdown
Author

Ok, CLA is signed now and I'm ready for feedback.

Best regards
Robert

@bob1de

bob1de commented Aug 22, 2017

Copy link
Copy Markdown
Author

I wanted to ask for some progress on this issue. Is there somebody willing to review it? It still merges without conflicts.

Best regards
Robert

@terryjreedy

Copy link
Copy Markdown
Member

Adding a new parameter is an enhancement that has not been mentioned on the issue, let alone approved.

@bob1de

bob1de commented Aug 28, 2017

Copy link
Copy Markdown
Author

Sorry, but what did you mean by "let alone approved"?

Just for reference, here is a quote of the docs for the new parameter of argparse.ArgumentParser() I suggest:

  • fromfile_parent_relative - Whether to treat paths of argument
    files as relative to the location of the file they are specified in
    (True) or to the current working directory (False) (default:
    False)

Best regards
Robert

@terryjreedy

Copy link
Copy Markdown
Member

My comment (which constituted my review) was in response to that. You propose to add a new feature with a specific name. AFAIK, neither Bethard nor any other core developer has approved of either the new feature as a concept or the specific name.

To seek such approval, you could post to python-ideas list. (I think most proposals other than for tkinter and IDLE should start there.) Briefly describe the idea and rationale and reference the issue and this PR. If you get a positive response, expect discussion of the option (parameter) name.

@bob1de

bob1de commented Aug 29, 2017

Copy link
Copy Markdown
Author

Thank you for your explanation. This is my first contribution to cpython, hence thinks went a bit wrong somehow.

@bob1de

bob1de commented Aug 29, 2017

Copy link
Copy Markdown
Author

@terryjreedy Ah! I didn't get your response at python-dev. That's why your comment here seemed out-of-context to me. Now I read it and things are clear. Thanks again!

@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 19, 2022
@MaxwellDupre

MaxwellDupre commented Mar 14, 2022

Copy link
Copy Markdown
Contributor

Got issue testing so did a full test then got:
422 tests OK.

2 tests failed:
test_embed test_ossaudiodev

[Irrelevant traceback of unrelelated failures delected by TJR.]

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Mar 15, 2022
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 14, 2022
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jul 28, 2022
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 28, 2022
@arhadthedev

Copy link
Copy Markdown
Member

You propose to add a new feature with a specific name. AFAIK, neither Bethard nor any other core developer has approved of either the new feature as a concept or the specific name.

@terryjreedy Was the approval achieved? If not, should the PR and issue be closed then?

/cc @bob1de

@bob1de

bob1de commented Feb 3, 2023

Copy link
Copy Markdown
Author

@arhadthedev No, this wasn't pursued any further from my side. It started as the sharing of a little code I used in a project and thought could also be beneficial to stdlib, but the process turned out more complex than expected. Had not much of an idea of the cpython contribution guidelines back then.

So I guess I'm better closing this right away and maybe start a fresh python-dev discussion on the issue eventually, correct?

@terryjreedy terryjreedy added stdlib Standard Library Python modules in the Lib/ directory type-feature A feature request or enhancement labels Feb 3, 2023
@terryjreedy terryjreedy changed the title bpo-30421: Added fromfile_parent_relative parameter + docs to argparse.ArgumentParser gh-74606: Add fromfile_parent_relative parameter to argparse.ArgumentParser Feb 3, 2023
@python python deleted a comment from github-actions Bot Feb 3, 2023
@terryjreedy

Copy link
Copy Markdown
Member

When this was submitted, the then expert listed in the expert's index was added as nosy, but he had become inactive. Another core dev worked on argparse a bit a year or two ago, and is doing other things now. I believe someone else has touched argparse recently, but not listed himself as an expert responsible for the module. Robert, if you are withdrawing the suggestion, perhaps close this and the issue. But if you still think it a good idea, I would leave at least the issue, for the next person who looks as the Argparse issues list Argparse issues.

@bob1de

bob1de commented Feb 3, 2023

Copy link
Copy Markdown
Author

@terryjreedy Thanks, then I'll close this PR and leave the issue open; I still think the way nested inclusion behaves right now can be irritating at least. Maybe someone picks up the idea later on or has an even better way to improve on this.

@bob1de bob1de closed this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review stale Stale PR or inactive for long period of time. stdlib Standard Library Python modules in the Lib/ directory type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants