Skip to content

[3.8] bpo-38698: Prevent UnboundLocalError to pop up in parse_message_id (GH-17277)#17476

Merged
miss-islington merged 1 commit into
python:3.8from
miss-islington:backport-bb81549-3.8
Dec 5, 2019
Merged

[3.8] bpo-38698: Prevent UnboundLocalError to pop up in parse_message_id (GH-17277)#17476
miss-islington merged 1 commit into
python:3.8from
miss-islington:backport-bb81549-3.8

Conversation

@miss-islington

@miss-islington miss-islington commented Dec 5, 2019

Copy link
Copy Markdown
Contributor

parse_message_id() was improperly using a token defined inside an exception
handler, which was raising UnboundLocalError on parsing an invalid value.

https://bugs.python.org/issue38698
(cherry picked from commit bb81549)

Co-authored-by: Claudiu Popa pcmanticore@gmail.com

https://bugs.python.org/issue38698

…ythonGH-17277)

parse_message_id() was improperly using a token defined inside an exception
handler, which was raising `UnboundLocalError` on parsing an invalid value.

https://bugs.python.org/issue38698
(cherry picked from commit bb81549)

Co-authored-by: Claudiu Popa <pcmanticore@gmail.com>

@maxking maxking left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islington

Copy link
Copy Markdown
Contributor Author

@PCManticore: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit e21aa61 into python:3.8 Dec 5, 2019
@miss-islington miss-islington deleted the backport-bb81549-3.8 branch December 5, 2019 17:42
@miss-islington

Copy link
Copy Markdown
Contributor Author

@PCManticore: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington

Copy link
Copy Markdown
Contributor Author

@PCManticore: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants