bpo-30447: Fix/skip the subinterpreters test on some platforms.#1791
Merged
ericsnowcurrently merged 4 commits intoMay 25, 2017
Merged
Conversation
|
@ericsnowcurrently, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zooba, @ncoghlan and @benjaminp to be potential reviewers. |
pitrou
reviewed
May 24, 2017
Member
There was a problem hiding this comment.
Can't you print out an informative message here? :-)
Member
Author
There was a problem hiding this comment.
Gah, I had meant to. Thanks for catching that.
ericsnowcurrently
force-pushed
the
fix-30447-subinterp-test
branch
from
5564cb4 to
e592cc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this is a relatively short-term fix that leaves the more important checks (e.g. interpreter ID) in place. As soon as I determine why pointers on some platforms are printing as 0x0, I'll sort this out more correctly. I suspect it relates to 32-bit vs. 64-bit.