bpo-30463 ABC has empty __slots__, with unittest#1822
Conversation
|
@aaronchall, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @tiran and @ezio-melotti to be potential reviewers. |
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
I think this is a simple but good idea.
|
Would be cool to have ABC available in 2.7... So what happens next, should I or someone else click "Close and comment"? |
It is not possible at this stage.
This PR can be approved and merged by someone with commit rights. |
|
LGTM. Please add a Misc/NEWS entry. Don't forget "Patch by Aaron Hall." at the end. |
| - Issue #25532: inspect.unwrap() will now only try to unwrap an object | ||
| sys.getrecursionlimit() times, to protect against objects which create a new | ||
| object on every attribute access. | ||
|
|
There was a problem hiding this comment.
Could you please remove the extra whitespace you added?
|
trailing whitespace removed and tests passed |
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
This doesn't much matter, but usually Misc/NEWS entries are added at the start of the section.
In any case the PR LGTM.
5 participants
No description provided.