Skip to content

bpo-28859: Fix return value of ismount on Windows#19109

Closed
digglife wants to merge 4 commits into
python:mainfrom
digglife:issue28859
Closed

bpo-28859: Fix return value of ismount on Windows#19109
digglife wants to merge 4 commits into
python:mainfrom
digglife:issue28859

Conversation

@digglife

@digglife digglife commented Mar 22, 2020

Copy link
Copy Markdown

When a path doest not acutally exist, ismount should return False
instead of raising FileNotFountError.

https://bugs.python.org/issue28859

When a path doest not acutally exist, `ismount` should return False
instead of raising FileNotFountError.
@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@digglife

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Comment thread Lib/ntpath.py Outdated
Comment thread Lib/ntpath.py Outdated
Comment thread Lib/test/test_ntpath.py Outdated
@digglife

digglife commented Apr 1, 2020

Copy link
Copy Markdown
Author

@zooba

Thanks for your review. I updated the code as your suggestion. Could you please take a look?

@csabella csabella requested a review from zooba May 23, 2020 20:05
@digglife

Copy link
Copy Markdown
Author

Wow, it's been a year since I sent this. Is there anything I can do to push it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants