bpo-40750: Support -d flag in the new parser#20340
Conversation
1cdeb88 to
1939494
Compare
lysnikolaou
left a comment
There was a problem hiding this comment.
I really like the output. One question: Would the non-ASCII characters create problems for people, whose terminals do not support UTF-8?
I would say it would be very uncommon that anyone would run python with -d (requires a debug build) in a terminal that does not support UTF-8 but I don't feel very strongly about those characters if anyone sees other problems. |
|
I'm personally a big believer in ASCII. I don't know how to type those other characters and have to Google their Unicode values every time. |
Fair enough, let's change them. Some suggestions for substituting characters or error/acceptance messages (the current ones are basically placeholders)? |
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
|
Ok, I have substituted the non-ascii characters for some close equivalents ( |
|
Example of the output now: |
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
(cherry picked from commit 800a35c) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
|
GH-20392 is a backport of this pull request to the 3.9 branch. |
|
|
Seems that some version Microsoft compiler does not like the linkage of |
https://bugs.python.org/issue40750