[3.9] bpo-40688: Use the correct parser in the peg_generator scripts (GH-20235)#20396
Merged
Merged
Conversation
…nGH-20235) The scripts in `Tools/peg_generator/scripts` mostly assume that `ast.parse` and `compile` use the old parser, since this was the state of things, while we were developing them. They need to be updated to always use the correct parser. `_peg_parser` is being extended to support both parsing and compiling with both parsers. (cherry picked from commit 9645930) Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
pablogsal
approved these changes
May 25, 2020
Contributor
Author
|
@lysnikolaou and @pablogsal: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@lysnikolaou and @pablogsal: Status check is done, and it's a success ✅ . |
1 similar comment
Contributor
Author
|
@lysnikolaou and @pablogsal: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scripts in
Tools/peg_generator/scriptsmostly assume thatast.parseandcompileuse the old parser, since this was thestate of things, while we were developing them. They need to be
updated to always use the correct parser.
_peg_parseris beingextended to support both parsing and compiling with both parsers.
(cherry picked from commit 9645930)
Co-authored-by: Lysandros Nikolaou lisandrosnik@gmail.com
https://bugs.python.org/issue40688