Skip to content

bpo-40724: Fix return type of heapctypewithbuffer_releasebuffer()#20685

Merged
scoder merged 1 commit into
python:masterfrom
remilapeyre:heapctypewithbuffer_releasebuffer
Jun 7, 2020
Merged

bpo-40724: Fix return type of heapctypewithbuffer_releasebuffer()#20685
scoder merged 1 commit into
python:masterfrom
remilapeyre:heapctypewithbuffer_releasebuffer

Conversation

@remilapeyre

@remilapeyre remilapeyre commented Jun 6, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown

CC @scoder

This function has no return value:

/Users/remi/src/cpython/Modules/_testcapimodule.c:6325:1: warning: control may reach end of non-void function [-Wreturn-type]
}

https://bugs.python.org/issue40724

@scoder scoder changed the title Fix return type of heapctypewithbuffer_releasebuffer() bpo-40724: Fix return type of heapctypewithbuffer_releasebuffer() Jun 7, 2020
@scoder scoder merged commit b8867e5 into python:master Jun 7, 2020
@miss-islington

miss-islington commented Jun 7, 2020

Copy link
Copy Markdown
Contributor

Thanks @remilapeyre for the PR, and @scoder for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@scoder

scoder commented Jun 7, 2020

Copy link
Copy Markdown
Contributor

Thanks!

@miss-islington

miss-islington commented Jun 7, 2020

Copy link
Copy Markdown
Contributor

Sorry, @remilapeyre and @scoder, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b8867e5d5aca33511942632b5f4e359b9245b2fa 3.9

@miss-islington

miss-islington commented Jun 7, 2020

Copy link
Copy Markdown
Contributor

Thanks @remilapeyre for the PR, and @scoder for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jun 7, 2020

Copy link
Copy Markdown
Contributor

Sorry @remilapeyre and @scoder, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker b8867e5d5aca33511942632b5f4e359b9245b2fa 3.9

@miss-islington

miss-islington commented Jun 7, 2020

Copy link
Copy Markdown
Contributor

Thanks @remilapeyre for the PR, and @scoder for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot

bedevere-bot commented Jun 7, 2020

Copy link
Copy Markdown

GH-20690 is a backport of this pull request to the 3.9 branch.

scoder pushed a commit that referenced this pull request Jun 7, 2020
@miss-islington
bpo-40724: Fix return type of test helper function heapctypewithbuffe…
1d711f2 
…r_releasebuffer() (GH-20685) (GH-20690)

(cherry picked from commit b8867e5)
Co-authored-by: Rémi Lapeyre <remi.lapeyre@lenstra.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@scoder scoder

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@remilapeyre @miss-islington @scoder @bedevere-bot @the-knights-who-say-ni