Skip to content

gh-85028: Don't set wShowWindow if startupinfo has STARTF_USESHOWWINDOW #20975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZackerySpytz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-85028: Don't set wShowWindow if startupinfo has STARTF_USESHOWWINDOW #20975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e27563
bpo-40851: Don't set wShowWindow if startupinfo has STARTF_USESHOWWINDOW
ZackerySpytz Jun 19, 2020
0fab27c
News
ZackerySpytz Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Lib/subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1401,8 +1401,9 @@ def _execute_child(self, args, executable, preexec_fn, close_fds,
close_fds = False

if shell:
startupinfo.dwFlags |= _winapi.STARTF_USESHOWWINDOW
startupinfo.wShowWindow = _winapi.SW_HIDE
if not startupinfo.dwFlags & _winapi.STARTF_USESHOWWINDOW:
startupinfo.dwFlags |= _winapi.STARTF_USESHOWWINDOW
startupinfo.wShowWindow = _winapi.SW_HIDE
comspec = os.environ.get("COMSPEC", "cmd.exe")
args = '{} /c "{}"'.format (comspec, args)

Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Windows/2020-06-19-00-14-52.bpo-40851.0-3EJP.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
On Windows, :class:`subprocess.Popen` no longer sets ``wShowWindow`` if the
``startupinfo`` argument has the flag ``STARTF_USESHOWWINDOW``.
Comment on lines +1 to +2

@serhiy-storchaka serhiy-storchaka Feb 28, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It describes what the code does, but not what it means for the user.

It can be acceptable in the commit message, but not in the NEWS entry. Please describe the change in terms of user visible effects.