Skip to content

bpo-41138: Fix trace CLI for non-UTF-8 files.#21177

Merged
serhiy-storchaka merged 2 commits into
python:masterfrom
serhiy-storchaka:trace-open-encoding
Jun 28, 2020
Merged

bpo-41138: Fix trace CLI for non-UTF-8 files.#21177
serhiy-storchaka merged 2 commits into
python:masterfrom
serhiy-storchaka:trace-open-encoding

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jun 27, 2020

Copy link
Copy Markdown
Member

Fix also a resource warning when store counts and module info.

https://bugs.python.org/issue41138

Fix also a resource warning when store counts and module info.
@@ -0,0 +1,2 @@
Fixed the :mod:`tarce` module CLI for Python source files with non-UTF-8

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/tarce/trace

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thank you @srinivasreddy!

@serhiy-storchaka serhiy-storchaka merged commit 04cdeb7 into python:master Jun 28, 2020
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the trace-open-encoding branch June 28, 2020 10:34
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 28, 2020
Fix also a resource warning when store counts and module info.
(cherry picked from commit 04cdeb7)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-21196 is a backport of this pull request to the 3.9 branch.

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 04cdeb7a5617c48102f45b965e683b12cdf934f8 3.8

miss-islington added a commit that referenced this pull request Jun 28, 2020
Fix also a resource warning when store counts and module info.
(cherry picked from commit 04cdeb7)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jun 28, 2020
Fix also a resource warning when store counts and module info..
(cherry picked from commit 04cdeb7)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-21200 is a backport of this pull request to the 3.8 branch.

serhiy-storchaka added a commit that referenced this pull request Jun 28, 2020
)

Fix also a resource warning when store counts and module info.
(cherry picked from commit 04cdeb7)
fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
Fix also a resource warning when store counts and module info.
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants