Skip to content

bpo-41158: IDLE: rewrite the code for handling file encoding#21215

Merged
serhiy-storchaka merged 4 commits into
python:masterfrom
serhiy-storchaka:idle-file-encoding
Jun 30, 2020
Merged

bpo-41158: IDLE: rewrite the code for handling file encoding#21215
serhiy-storchaka merged 4 commits into
python:masterfrom
serhiy-storchaka:idle-file-encoding

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jun 29, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka added type-feature A feature request or enhancement skip news labels Jun 29, 2020
terryjreedy
terryjreedy reviewed Jun 30, 2020
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at first glance, but I want to look again. #21214 changes context lines 60 and 61. This might cause an easily fixed merge conflict.

@serhiy-storchaka serhiy-storchaka merged commit 694d31e into python:master Jun 30, 2020
@serhiy-storchaka serhiy-storchaka deleted the idle-file-encoding branch June 30, 2020 06:33
@miss-islington

miss-islington commented Jul 1, 2020

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jul 1, 2020

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jul 1, 2020

Copy link
Copy Markdown

GH-21259 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2020
@serhiy-storchaka @miss-islington
bpo-41158: IDLE: rewrite the code for handling file encoding (pythonG…
247e879 
…H-21215)

(cherry picked from commit 694d31e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

bedevere-bot commented Jul 1, 2020

Copy link
Copy Markdown

GH-21260 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2020
@serhiy-storchaka @miss-islington
bpo-41158: IDLE: rewrite the code for handling file encoding (pythonG…
68684e0 
…H-21215)

(cherry picked from commit 694d31e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Jul 1, 2020
@miss-islington @serhiy-storchaka
bpo-41158: IDLE: rewrite the code for handling file encoding (GH-21215)
fe0175f 
(cherry picked from commit 694d31e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington

miss-islington commented Jul 1, 2020

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jul 1, 2020

Copy link
Copy Markdown

GH-21267 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2020
@serhiy-storchaka @miss-islington
bpo-41158: IDLE: rewrite the code for handling file encoding (pythonG…
2105175 
…H-21215)

(cherry picked from commit 694d31e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Jul 1, 2020
@miss-islington @serhiy-storchaka
bpo-41158: IDLE: rewrite the code for handling file encoding (GH-21215)
c3fa753 
(cherry picked from commit 694d31e)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy left review comments

Assignees

No one assigned

Labels

skip news type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @miss-islington @bedevere-bot @terryjreedy @the-knights-who-say-ni