Skip to content

bpo-33987: ttk frame inside search dialog toplevel#22942

Merged
terryjreedy merged 6 commits into
python:masterfrom
roseman:searchbase-frame-33987
Oct 25, 2020
Merged

bpo-33987: ttk frame inside search dialog toplevel#22942
terryjreedy merged 6 commits into
python:masterfrom
roseman:searchbase-frame-33987

Conversation

@roseman

@roseman roseman commented Oct 24, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@roseman roseman requested a review from terryjreedy as a code owner October 24, 2020 15:49
terryjreedy
terryjreedy reviewed Oct 25, 2020
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes are correct pending a deeper refactoring.
I have made the needed changes to the tests and will push commits that include a blurb.

Comment thread Lib/idlelib/idle_test/test_searchbase.py Outdated
equal = self.assertEqual
self.dialog.row = 0
self.dialog.top = self.root
self.dialog.top = self.dialog.frame = self.root

@terryjreedy terryjreedy Oct 25, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct fix to make the tests pass after inserting the Frame is self.dialog.frame = Frame(self.root). The new frame isolates all other widgets from the top level, and this isolation is a reason for inserting the frame independent of the appearance change on some systems, and should be part of the test. (Indeed, self.dialog.top does not exist during the tests being modified.)

@terryjreedy

terryjreedy commented Oct 25, 2020

Copy link
Copy Markdown
Member

This time an Azure Pipelines Ubuntu ttk Combobox timeout

@terryjreedy terryjreedy merged commit 5df6c99 into python:master Oct 25, 2020
@miss-islington

miss-islington commented Oct 25, 2020

Copy link
Copy Markdown
Contributor

Thanks @roseman for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Oct 25, 2020

Copy link
Copy Markdown
Contributor

Thanks @roseman for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 25, 2020
@roseman @miss-islington
bpo-33987: Add master ttk Frame to IDLE search dialogs (pythonGH-22942)
2fad9d7 
(cherry picked from commit 5df6c99)

Co-authored-by: Mark Roseman <mark@markroseman.com>
@bedevere-bot

bedevere-bot commented Oct 25, 2020

Copy link
Copy Markdown

GH-22956 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 25, 2020
@roseman @miss-islington
bpo-33987: Add master ttk Frame to IDLE search dialogs (pythonGH-22942)
7f96abc 
(cherry picked from commit 5df6c99)

Co-authored-by: Mark Roseman <mark@markroseman.com>
@bedevere-bot

bedevere-bot commented Oct 25, 2020

Copy link
Copy Markdown

GH-22957 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Oct 25, 2020
@miss-islington @roseman
bpo-33987: Add master ttk Frame to IDLE search dialogs (GH-22942)
9cf26b0 
(cherry picked from commit 5df6c99)

Co-authored-by: Mark Roseman <mark@markroseman.com>
miss-islington added a commit that referenced this pull request Oct 25, 2020
@miss-islington @roseman
bpo-33987: Add master ttk Frame to IDLE search dialogs (GH-22942)
8485d3b 
(cherry picked from commit 5df6c99)

Co-authored-by: Mark Roseman <mark@markroseman.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@roseman @adorilson
bpo-33987: Add master ttk Frame to IDLE search dialogs (pythonGH-22942)
440e337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

+1 more reviewer

@E-Paine E-Paine E-Paine approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@roseman @terryjreedy @miss-islington @bedevere-bot @E-Paine @the-knights-who-say-ni