gh-48739: tests(tests_shutil): fix comment with check_args_to_onerror#22968
Open
blueyed wants to merge 1 commit into
Open
gh-48739: tests(tests_shutil): fix comment with check_args_to_onerror#22968blueyed wants to merge 1 commit into
blueyed wants to merge 1 commit into
Conversation
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
Contributor
Author
|
I think this is still legit, and only changes a comment. Will trigger a rebuild. |
- `os.unlink` is used since 2100b42. - `os.rmdir` is used since 67be92b. (Note that the special case for Linux/ZFS is not covered [1], and might actually not work anymore since the changes around handling/setting `self.errorState`.) 1: https://codecov.io/gh/python/cpython/src/492d513ccb/Lib/test/test_shutil.py#L354...355 Ref: https://bugs.python.org/issue4489
blueyed
force-pushed
the
test-fix-comment
branch
from
6c5b512 to
220203c
Compare
github-actions
Bot
removed
the
stale
Member
|
https://bugs.python.org/issue4489 is closed. What is the status of this PR? |
|
The following commit authors need to sign the Contributor License Agreement: |
StanFromIreland
changed the title
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.unlinkis used since 2100b42.os.rmdiris used since 67be92b.(Note that the special case for Linux/ZFS is not covered [1], and might
actually not work anymore since the changes around handling/setting
self.errorState.)1: https://codecov.io/gh/python/cpython/src/492d513ccb/Lib/test/test_shutil.py#L354...355
Ref: https://bugs.python.org/issue4489
https://bugs.python.org/issue4489