bpo-11998: Patch smtplib.py#23490
Conversation
This update was made to meet 2 needs: - Bug Fix: python#11998 - Allow backward compatibility with Python 2.7.9 or higher.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
Python2 is EOL. We does not support Python 2.7.x |
|
@corona10 |
|
I believe this should be split into two pull requests – one fixing a bug and another improving backward compatibility. Right now I can barely see what the actual fix is here. But on the backward compatibility front:
I'd say because it may add a maintenance burden (arguably not in this case) or affect the code negatively (like |
|
Ok, I drop the backward compatibility... |
|
In general, a pull request should be created against the master branch and manually backported if the automatic backpot fails. This is the project policy. 2.7 branch is frozen and doesn't accept any change, sorry. I'm closing this PR; it removes all audit calls which is not acceptable. |
6 participants
This update was made to meet 2 needs:
https://bugs.python.org/issue36094