Skip to content

bpo-42482: remove reference to exc_traceback from TracebackException #23531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 7 commits into from
Dec 1, 2020
Merged

bpo-42482: remove reference to exc_traceback from TracebackException #23531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3233ecd
bpo-42482: remove reference to exception traceback from TracebackExce…
iritkatriel Nov 27, 2020
5459051
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 27, 2020
920f808
added refcount check to unit tests
iritkatriel Nov 27, 2020
16120a1
create ref to the TracebackException object
iritkatriel Nov 27, 2020
47c13ad
no need to call format() in refcnt test
iritkatriel Nov 27, 2020
d4fbfb2
remove unnecessary boolean
iritkatriel Nov 29, 2020
1035665
indent stack.format() line as well
iritkatriel Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions Lib/test/test_traceback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,6 +1123,18 @@ def test_context(self):
self.assertEqual(exc_info[0], exc.exc_type)
self.assertEqual(str(exc_info[1]), str(exc))

def test_no_refs_to_exception_and_traceback_objects(self):
try:
1/0
except Exception:
exc_info = sys.exc_info()

refcnt1 = sys.getrefcount(exc_info[1])
refcnt2 = sys.getrefcount(exc_info[2])
exc = traceback.TracebackException(*exc_info)
self.assertEqual(sys.getrefcount(exc_info[1]), refcnt1)
self.assertEqual(sys.getrefcount(exc_info[2]), refcnt2)

def test_comparison_basic(self):
try:
1/0
Expand Down Expand Up @@ -1172,6 +1184,16 @@ def raise_with_locals():
exc7 = traceback.TracebackException(*exc_info, limit=-2, capture_locals=True)
self.assertNotEqual(exc6, exc7)

def test_comparison_equivalent_exceptions_are_equal(self):
excs = []
for _ in range(2):
try:
1/0
except:
excs.append(traceback.TracebackException(*sys.exc_info()))
self.assertEqual(excs[0], excs[1])
self.assertEqual(list(excs[0].format()), list(excs[1].format()))

def test_unhashable(self):
class UnhashableException(Exception):
def __eq__(self, other):
Expand Down
5 changes: 2 additions & 3 deletions Lib/traceback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,6 @@ def __init__(self, exc_type, exc_value, exc_traceback, *, limit=None,
_seen=_seen)
else:
context = None
self.exc_traceback = exc_traceback
self.__cause__ = cause
self.__context__ = context
self.__suppress_context__ = \
Expand Down Expand Up @@ -627,7 +626,7 @@ def format(self, *, chain=True):
not self.__suppress_context__):
yield from self.__context__.format(chain=chain)
yield _context_message
if self.exc_traceback is not None:
if self.stack:
yield 'Traceback (most recent call last):\n'
yield from self.stack.format()
yield from self.stack.format()
yield from self.format_exception_only()
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2020-11-27-16-46-58.bpo-42482.EJC3sd.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
:class:`~traceback.TracebackException` no longer holds a reference to the exception's traceback object. Consequently, instances of TracebackException for equivalent but non-equal exceptions now compare as equal.