Skip to content

bpo-43960: reset global breakpoint state at the beginning of a pdb te…#25673

Merged
vstinner merged 1 commit into
python:masterfrom
iritkatriel:bpo-43960
Apr 28, 2021
Merged

bpo-43960: reset global breakpoint state at the beginning of a pdb te…#25673
vstinner merged 1 commit into
python:masterfrom
iritkatriel:bpo-43960

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Apr 27, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

…st to make it deterministic

https://bugs.python.org/issue43960

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Apr 27, 2021
@iritkatriel iritkatriel requested a review from vstinner April 27, 2021 22:52
@vstinner vstinner merged commit 21b02b5 into python:master Apr 28, 2021
@miss-islington

miss-islington commented Apr 28, 2021

Copy link
Copy Markdown
Contributor

Thanks @iritkatriel for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Apr 28, 2021

Copy link
Copy Markdown
Contributor

Thanks @iritkatriel for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Apr 28, 2021

Copy link
Copy Markdown
Contributor

Sorry @iritkatriel and @vstinner, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 21b02b5f4018474620676be04310f7d230a464ea 3.8

@bedevere-bot

bedevere-bot commented Apr 28, 2021

Copy link
Copy Markdown

GH-25681 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 28, 2021
@iritkatriel @miss-islington
bpo-43960: test_pdb resets breakpoints (pythonGH-25673)
9e99acc 
Reset global breakpoint state at the beginning of
test_pdb_next_command_in_generator_for_loop() to make it deterministic.
(cherry picked from commit 21b02b5)

Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>
@miss-islington

miss-islington commented Apr 28, 2021

Copy link
Copy Markdown
Contributor

Thanks @iritkatriel for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Apr 28, 2021

Copy link
Copy Markdown

GH-25682 is a backport of this pull request to the 3.8 branch.

@vstinner

vstinner commented Apr 28, 2021

Copy link
Copy Markdown
Member

Oh, thanks for the fix @iritkatriel, it fix my issue and it LGTM. I merged your fix and backported it to 3.8 and 3.9.

@iritkatriel iritkatriel deleted the bpo-43960 branch May 11, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Assignees

@vstinner vstinner

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iritkatriel @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni