bpo-29854: Skip history-size test on older readline#2621
Conversation
|
@nirs, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vadmium, @ronaldoussoren and @benjaminp to be potential reviewers. |
|
Warning: untested yet. |
There was a problem hiding this comment.
I think we still need to skip the test if editline is available since it uses a different configuration format than readline.
There was a problem hiding this comment.
Right, we have several reasons for skiping:
- libedit on os x 10.11.6 does not implement history size - I tested using the libedit special format.
- newer version on os x not tested yet, I don't want to add a possibly broken test
- readline < 6.0 does not support history size
There was a problem hiding this comment.
We've been using _READLINE_VERSION without a fallback value in test_init in line 116 for a while and I don't remember any issue reported on bugs.p.o because of it. I think we can safely drop the fallback value.
There was a problem hiding this comment.
I think we should fix the old code not to assume private attributes, same as @Haypo patch for printing readline version.
For this patch I'll drop the fallback.
Turns out that history-size was added in readline 6.0. This explain why this tests fail on FreeBSd when using readline 5.2. We skip now the history size if readline does not support it. See https://cnswww.cns.cwru.edu/php/chet/readline/CHANGES.
|
Version 2 addresses @berkerpeksag comments. Tested on Fedora 25 (ok), FreeBSD 11 (ok), OS X 10.11.6 (skipped) |
|
Thanks! |
Turns out that history-size was added in readline 6.0. This explain why this tests fail on FreeBSD when using readline 5.2. We skip now the history size if readline does not support it. See https://cnswww.cns.cwru.edu/php/chet/readline/CHANGES for details.
Turns out that history-size was added in readline 6.0. This explain why this tests fail on FreeBSD when using readline 5.2. We skip now the history size if readline does not support it. See https://cnswww.cns.cwru.edu/php/chet/readline/CHANGES for details.
4 participants
Turns out that history-size was added in readline 6.0. This explain why
this tests fail on FreeBSd and OS X using readline version 5.2 and 5.1.
Skipping the test now based on readline version instead of libedit
emulation.
See https://cnswww.cns.cwru.edu/php/chet/readline/CHANGES.
@berkerpeksag, @Haypo, @vadmium please review.