Skip to content

bpo-44544: add textwrap placeholder arg#27671

Merged
asvetlov merged 3 commits into
python:mainfrom
akulakov:44544-Add-textwrap-placeholder-arg
Mar 19, 2022
Merged

bpo-44544: add textwrap placeholder arg#27671
asvetlov merged 3 commits into
python:mainfrom
akulakov:44544-Add-textwrap-placeholder-arg

Conversation

@akulakov

@akulakov akulakov commented Aug 9, 2021

Copy link
Copy Markdown
Contributor

A small follow up fix to the linked issue -- add placeholder arg which does have effect in these 2 functions.

https://bugs.python.org/issue44544

@github-actions

github-actions Bot commented Sep 9, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Sep 9, 2021
@MaxwellDupre

Copy link
Copy Markdown
Contributor

Looks off:
placeholder=' [...]')
placeholder='[...]')

@akulakov

Copy link
Copy Markdown
Contributor Author

@MaxwellDupre It looks a bit better if there is a leading space (and consistent with existing placeholder default in this module):

my line of text[...]
my line of text [...]

@MaxwellDupre MaxwellDupre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @akulakov for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 19, 2022
(cherry picked from commit cb7874f)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 19, 2022
(cherry picked from commit cb7874f)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-31992 is a backport of this pull request to the 3.10 branch.

@bedevere-bot

Copy link
Copy Markdown

GH-31993 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Mar 19, 2022
(cherry picked from commit cb7874f)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
miss-islington added a commit that referenced this pull request Mar 19, 2022
(cherry picked from commit cb7874f)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
@akulakov akulakov deleted the 44544-Add-textwrap-placeholder-arg branch March 21, 2022 15:22
@akulakov

Copy link
Copy Markdown
Contributor Author

@MaxwellDupre @asvetlov thanks for reviewing!

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
(cherry picked from commit cb7874f)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants