Skip to content

[3.10] makefile: remove unused SGI_ABI variable (GH-29325)#29368

Merged
ambv merged 1 commit into
python:3.10from
miss-islington:backport-38982ab-3.10
Nov 2, 2021
Merged

[3.10] makefile: remove unused SGI_ABI variable (GH-29325)#29368
ambv merged 1 commit into
python:3.10from
miss-islington:backport-38982ab-3.10

Conversation

@miss-islington

Copy link
Copy Markdown
Contributor

SGI_ABI support was removed in [1] but this variable was never removed
from the makefile. Currently, it is just a bad variable that does not
get replaced by the configure script.

[1] #3294

Signed-off-by: Filipe Laíns lains@riseup.net
(cherry picked from commit 38982ab)

Co-authored-by: Filipe Laíns lains@riseup.net

SGI_ABI support was removed in [1] but this variable was never removed
from the makefile. Currently, it is just a bad variable that does not
get replaced by the configure script.

[1] python#3294

Signed-off-by: Filipe Laíns <lains@riseup.net>
(cherry picked from commit 38982ab)

Co-authored-by: Filipe Laíns <lains@riseup.net>
@miss-islington

Copy link
Copy Markdown
Contributor Author

@FFY00 and @ambv: Status check is done, and it's a failure ❌ .

1 similar comment
@miss-islington

Copy link
Copy Markdown
Contributor Author

@FFY00 and @ambv: Status check is done, and it's a failure ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@FFY00 and @ambv: Status check is done, and it's a failure ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@FFY00 and @ambv: Status check is done, and it's a success ✅ .

@ambv ambv merged commit 8d609b2 into python:3.10 Nov 2, 2021
@miss-islington miss-islington deleted the backport-38982ab-3.10 branch November 2, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants