Skip to content

bpo-46009: Do not exhaust generator when send() method raises#29986

Merged
markshannon merged 3 commits into
python:mainfrom
faster-cpython:fix-46009
Dec 8, 2021
Merged

bpo-46009: Do not exhaust generator when send() method raises#29986
markshannon merged 3 commits into
python:mainfrom
faster-cpython:fix-46009

Conversation

@markshannon

@markshannon markshannon commented Dec 8, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

I've tried to keep this PR as small as possible, to assist backporting to 3.10.
As a consequence, the GEN_START instruction remains, even though it is now equivalent to POP_TOP.

https://bugs.python.org/issue46009

@markshannon markshannon requested a review from 1st1 as a code owner December 8, 2021 11:01
@markshannon markshannon added the needs backport to 3.10 only security fixes label Dec 8, 2021
@markshannon markshannon merged commit 69806b9 into python:main Dec 8, 2021
@miss-islington

miss-islington commented Dec 8, 2021

Copy link
Copy Markdown
Contributor

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Dec 8, 2021

Copy link
Copy Markdown
Contributor

Sorry, @markshannon, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 69806b9516dbe092381f3ef884c7c64bb9b8414a 3.10

markshannon added a commit that referenced this pull request Dec 8, 2021
@markshannon
[3.10] bpo-46009: Do not exhaust generator when send() method raises (G…
e85dc18 
…H-29986).

(cherry picked from commit 69806b9)

Co-authored-by: Mark Shannon <mark@hotpy.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Dec 8, 2021
@bedevere-bot

bedevere-bot commented Dec 8, 2021

Copy link
Copy Markdown

GH-29988 is a backport of this pull request to the 3.10 branch.

@markshannon markshannon mentioned this pull request Dec 8, 2021
Merged
pablogsal pushed a commit that referenced this pull request Dec 8, 2021
@markshannon
[3.10] bpo-46009: Do not exhaust generator when send() method raises (G…
99c7232 
…H-29986). (GH-29988)

* [3.10] bpo-46009: Do not exhaust generator when send() method raises (GH-29986).
(cherry picked from commit 69806b9)

Co-authored-by: Mark Shannon <mark@hotpy.org>

* Rename variable after cherry-pick.

* Add NULL check.
@markshannon markshannon deleted the fix-46009 branch January 6, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees

@markshannon markshannon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@markshannon @miss-islington @bedevere-bot @pablogsal @the-knights-who-say-ni